-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Changing auth to use implicit environment. #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gcloud/storage/test_connection.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. Tough that the regression tests don't run on Travis until after the merge, though. |
|
Tough but worth it for the speed-up. I ran them lots and lots though. I was actually planning on letting them fail once before the new environment variables are set up and then re-running after. WDYT? |
|
I just pushed 1a1dac0, so we can wait until that passes before merging. |
|
"Fire when ready, Gridley!" |
CONTRIBUTING.rst
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@silvolu addressed the incorrect description in 78adc96 This fixes #247 though that is the very issue @craigcitro and I are trying to sort out in googleapis/oauth2client#93. #335 is in some sense already done but I still plan to
This does not address #337 in total. I wanted things like dataset.get_dataset()to work without having to pass in a dataset ID if one could be implied from the environment i.e. via GCE or GAE specific environ vars / metadata or via an environment variable. |
|
Feel free to merge if there is nothing else to discuss. I am grading a final right now so am a bit MIA. |
|
Maybe better not merge until we can figure why the trunk has broken regression tests. Of course, they are passing in my sandbox. Looks like @silvolu kicked off a re-run? |
|
@tseaver I did, this one looks extremely transient :) |
|
Build is back to green, merging this one. |
Changing auth to use implicit environment.
|
There's a decryption error on the credentials, I think @dhermes encrypted the file in his fork. I'll update the credentials file. |
|
See my previous comment. The |
|
@dhermes I've set that variable. |
|
Green makes Silvano happy: |
|
Thanks @silvolu. We are green! w00t |
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
#419) chore: Update test-samples-impl.sh python3.6 --> python3.9 (#418) Source-Link: googleapis/synthtool@1f07110 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a5d81b61dfd1a432d3c03f51a25d2e71b37be24da509966d50724aea7c57c5c2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: nicain <nicholascain@google.com> fix test
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v3` -> `v4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google-cloud-bigquery](https://togithub.com/googleapis/python-bigquery) | | patch | `==3.3.0` -> `==3.3.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [protobuf](https://developers.google.com/protocol-buffers/) | | major | `>= 3.19.0, <4.0.0dev` -> `>=4.21.4, <4.22.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-python</summary> ### [`v4`](https://togithub.com/actions/setup-python/compare/v3...v4) [Compare Source](https://togithub.com/actions/setup-python/compare/v3...v4) </details> <details> <summary>googleapis/python-bigquery</summary> ### [`v3.3.1`](https://togithub.com/googleapis/python-bigquery/blob/HEAD/CHANGELOG.md#​331-httpsgithubcomgoogleapispython-bigquerycomparev330v331-2022-08-09) ##### Bug Fixes - **deps:** allow pyarrow < 10 ([#​1304](https://togithub.com/googleapis/python-bigquery/issues/1304)) ([13616a9](https://togithub.com/googleapis/python-bigquery/commit/13616a910ba2e9b7bc3595847229b56e70c99f84)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-dlp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1MC40In0=-->
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* feat: Add routing information in Cloud Build GRPC clients PiperOrigin-RevId: 547283196 Source-Link: googleapis/googleapis@64d54ff Source-Link: googleapis/googleapis-gen@1de1822 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWRlMTgyMjExMDliNGEwMjVjMGIyZThjMjUzMjRjYjAxYjZkZjYyNiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Revert breaking change of main pattern PiperOrigin-RevId: 547506413 Source-Link: googleapis/googleapis@8080bbe Source-Link: googleapis/googleapis-gen@ac98388 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWM5ODM4OGJiODMyZGJlYmMwYmNkNmI3NDgwMDEwNTczYzBiYmRjNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
#419) * chore(deps): update all dependencies * revert changes and ignore future changes for environment specific pins Co-authored-by: Anthonios Partheniou <partheniou@google.com>
#419) * chore(deps): update all dependencies * revert changes and ignore future changes for environment specific pins Co-authored-by: Anthonios Partheniou <partheniou@google.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-bigquery](https://togithub.com/googleapis/python-bigquery) | `==2.30.1` -> `==2.31.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google-cloud-bigquery-storage](https://togithub.com/googleapis/python-bigquery-storage) | `==2.10.0` -> `==2.10.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [google-cloud-testutils](https://togithub.com/googleapis/python-test-utils) | `==1.1.0` -> `==1.3.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pandas](https://pandas.pydata.org) ([source](https://togithub.com/pandas-dev/pandas)) | `==1.3.4` -> `==1.3.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pyarrow](https://arrow.apache.org/) | `==6.0.0` -> `==6.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-bigquery</summary> ### [`v2.31.0`](https://togithub.com/googleapis/python-bigquery/blob/HEAD/CHANGELOG.md#​2310-httpswwwgithubcomgoogleapispython-bigquerycomparev2301v2310-2021-11-24) [Compare Source](https://togithub.com/googleapis/python-bigquery/compare/v2.30.1...v2.31.0) ##### Features - allow cell magic body to be a $variable ([#​1053](https://www.togithub.com/googleapis/python-bigquery/issues/1053)) ([3a681e0](https://www.github.com/googleapis/python-bigquery/commit/3a681e046819df18118aa0b2b5733416d004c9b3)) - promote `RowIterator.to_arrow_iterable` to public method ([#​1073](https://www.togithub.com/googleapis/python-bigquery/issues/1073)) ([21cd710](https://www.github.com/googleapis/python-bigquery/commit/21cd71022d60c32104f8f90ee2ca445fbb43f7f3)) ##### Bug Fixes - apply timeout to all resumable upload requests ([#​1070](https://www.togithub.com/googleapis/python-bigquery/issues/1070)) ([3314dfb](https://www.github.com/googleapis/python-bigquery/commit/3314dfbed62488503dc41b11e403a672fcf71048)) ##### Dependencies - support OpenTelemetry >= 1.1.0 ([#​1050](https://www.togithub.com/googleapis/python-bigquery/issues/1050)) ([4616cd5](https://www.github.com/googleapis/python-bigquery/commit/4616cd58d3c6da641fb881ce99a87dcdedc20ba2)) ##### [2.30.1](https://www.github.com/googleapis/python-bigquery/compare/v2.30.0...v2.30.1) (2021-11-04) ##### Bug Fixes - error if eval()-ing repr(SchemaField) ([#​1046](https://www.togithub.com/googleapis/python-bigquery/issues/1046)) ([13ac860](https://www.github.com/googleapis/python-bigquery/commit/13ac860de689ea13b35932c67042bc35e388cb30)) ##### Documentation - show gcloud command to authorize against sheets ([#​1045](https://www.togithub.com/googleapis/python-bigquery/issues/1045)) ([20c9024](https://www.github.com/googleapis/python-bigquery/commit/20c9024b5760f7ae41301f4da54568496922cbe2)) - use stable URL for pandas intersphinx links ([#​1048](https://www.togithub.com/googleapis/python-bigquery/issues/1048)) ([73312f8](https://www.github.com/googleapis/python-bigquery/commit/73312f8f0f22ff9175a4f5f7db9bb438a496c164)) </details> <details> <summary>googleapis/python-bigquery-storage</summary> ### [`v2.10.1`](https://togithub.com/googleapis/python-bigquery-storage/blob/HEAD/CHANGELOG.md#​2101-httpswwwgithubcomgoogleapispython-bigquery-storagecomparev2100v2101-2021-11-11) [Compare Source](https://togithub.com/googleapis/python-bigquery-storage/compare/v2.10.0...v2.10.1) </details> <details> <summary>googleapis/python-test-utils</summary> ### [`v1.3.1`](https://togithub.com/googleapis/python-test-utils/blob/HEAD/CHANGELOG.md#​131-httpswwwgithubcomgoogleapispython-test-utilscomparev130v131-2021-12-07) [Compare Source](https://togithub.com/googleapis/python-test-utils/compare/v1.3.0...v1.3.1) ### [`v1.3.0`](https://togithub.com/googleapis/python-test-utils/blob/HEAD/CHANGELOG.md#​130-httpswwwgithubcomgoogleapispython-test-utilscomparev120v130-2021-11-16) [Compare Source](https://togithub.com/googleapis/python-test-utils/compare/v1.2.0...v1.3.0) ##### Features - add 'py.typed' declaration ([#​73](https://www.togithub.com/googleapis/python-test-utils/issues/73)) ([f8f5f0a](https://www.github.com/googleapis/python-test-utils/commit/f8f5f0a194b2420b2fee1cf88ac50220d3ba1538)) ### [`v1.2.0`](https://togithub.com/googleapis/python-test-utils/blob/HEAD/CHANGELOG.md#​120-httpswwwgithubcomgoogleapispython-test-utilscomparev110v120-2021-10-18) [Compare Source](https://togithub.com/googleapis/python-test-utils/compare/v1.1.0...v1.2.0) ##### Features - add support for python 3.10 ([#​68](https://www.togithub.com/googleapis/python-test-utils/issues/68)) ([d93b6a1](https://www.github.com/googleapis/python-test-utils/commit/d93b6a11e3bfade2b29ab90ed3bc2c384beb01cd)) </details> <details> <summary>pandas-dev/pandas</summary> ### [`v1.3.5`](https://togithub.com/pandas-dev/pandas/releases/v1.3.5) [Compare Source](https://togithub.com/pandas-dev/pandas/compare/v1.3.4...v1.3.5) This is a patch release in the 1.3.x series and includes some regression fixes. We recommend that all users upgrade to this version. See the [full whatsnew](https://pandas.pydata.org/pandas-docs/version/1.3.5/whatsnew/v1.3.5.html) for a list of all the changes. The release will be available on the defaults and conda-forge channels: conda install pandas Or via PyPI: python3 -m pip install --upgrade pandas Please report any issues with the release on the [pandas issue tracker](https://togithub.com/pandas-dev/pandas/issues). </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-bigquery-pandas).
* chore(deps): update all dependencies * See googleapis/synthtool#1910 * See googleapis/synthtool#1910 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update actions/setup-python action to v4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…ic enums (#419) * feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: Add `OR` query support docs: Minor documentation formatting and cleanup PiperOrigin-RevId: 509848726 Source-Link: googleapis/googleapis@b9351b4 Source-Link: googleapis/googleapis-gen@99317db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTkzMTdkYjY4MjcxODVlOGNhZThlZWI0NjEzN2NkODFjZDJkNmE1NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Add service_yaml_parameters to py_gapic_library BUILD.bazel targets PiperOrigin-RevId: 510187992 Source-Link: googleapis/googleapis@5edc235 Source-Link: googleapis/googleapis-gen@b0bedb7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBiZWRiNzJlNDc2NWEzZTBiNjc0YTI4YzUwZWEwZjlhOWIyNmE4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@7e1f6da Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:a1a891041baa4ffbe1a809ac1b8b9b4a71887293c9101c88e8e255943c5aec2d Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…419) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…419) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* Use collections.abc, fixes #418 * Python 2.7 compat fix * Fix check
FWIW the only real code changes occur in
gcloud/credentials.pygcloud/datastore/__init__.pygcloud/datastore/demo/__init__.pygcloud/storage/__init__.pygcloud/storage/connection.py-- Some helpers added here should probably be moved elsewhere. Maybe I file a bug?gcloud/storage/demo/__init__.pyregression/regression_utils.pyAlso note that googleapis/oauth2client#93 may be problematic for us, but only in the short term (on the order of days).
Also, I still need to update the encrypted environment variables on Travis.