Updates from #2344 for speech API. by daspecster · Pull Request #2495 · googleapis/google-cloud-python

daspecster · 2016-10-04T18:40:11Z

Update async_recognize() and sync_recognize() method signatures and examples.
Add more examples showing usage of other options.

docs/speech-usage.rst

 The :meth:`~google.cloud.speech.Client.sync_recognize` method converts speech
 data to text and returns alternative text transcriptons.

+This example uses ``language_code='en-GB'`` to better recognize a dialect from


dhermes

Looks mostly good. Assuming tests are green, these changes should be easy to make / uncontroversial.

docs/speech-usage.rst

-     ...     None, 'gs://my-bucket/recording.flac',
-     ...     'FLAC', 16000, max_alternatives=2)
+     ...     'FLAC', 16000, source_uri='gs://my-bucket/recording.flac',
+     ...     language_code='en-GB', max_alternatives=2, )


docs/speech-usage.rst

+  ...     print('transcript: ' + alternative['transcript'])
+  ...     print('confidence: ' + alternative['confidence'])
+  ====================
+  transcript: Hello, this is a f****** test


speech/google/cloud/speech/client.py

    _connection_class = Connection

-    def async_recognize(self, content, source_uri, encoding, sample_rate,
+    def async_recognize(self, encoding, sample_rate, content=None,


speech/google/cloud/speech/client.py

                            re-sampling).

+        :type content: bytes
+        :param content: Byte stream of audio.


speech/google/cloud/speech/client.py

                                 omitted, profanities won't be filtered out.

+        :type source_uri: str
+        :param source_uri: URI that points to a file that contains audio


daspecster · 2016-10-05T15:05:13Z

Updated! LMKWYT @dhermes @tseaver

daspecster · 2016-10-05T15:06:05Z

Also @dhermes if you want I can hold off on this if you want #2500 in first.

daspecster · 2016-10-06T17:42:51Z

@dhermes was there anything else on this?

speech/google/cloud/speech/__init__.py

 """Google Cloud Speech API wrapper."""

 from google.cloud.speech.client import Client
-from google.cloud.speech.client import Encoding


dhermes · 2016-10-06T17:44:55Z

@daspecster I haven't followed since @tseaver requested the Sample class. If he is OK with the changes I am OK with them.

tseaver

The change to the Sample class LGTM. Do we need to add a Client.sample() factory (basically to ease the developer's need to do extra imports).

daspecster · 2016-10-06T17:48:38Z

@tseaver I think you may have eluded to that in your sample and I didn't make the connection so I took that out.

I'll add that and push it back up.

daspecster · 2016-10-06T18:37:42Z

@tseaver added the @staticmethod on speech.client.Client. LMKWYT!

daspecster · 2016-10-06T19:28:22Z

Thanks @tseaver!

Updates from googleapis#2344 for speech API.

Updates from googleapis#2344 for speech API.

8a35c54

daspecster added the api: speech Issues related to the Speech-to-Text API. label Oct 4, 2016

daspecster assigned tseaver and dhermes Oct 4, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2016

dhermes reviewed Oct 4, 2016

View reviewed changes

dhermes suggested changes Oct 4, 2016

View reviewed changes

Update argument order.

02e9e7d

daspecster force-pushed the cleanup-speech branch 2 times, most recently from 0a585b5 to b472c07 Compare October 5, 2016 05:47

Add Sample class to speech API.

c7b159d

daspecster force-pushed the cleanup-speech branch from b472c07 to c7b159d Compare October 5, 2016 06:03

dhermes reviewed Oct 6, 2016

View reviewed changes

speech/google/cloud/speech/__init__.py

"""Google Cloud Speech API wrapper."""

from google.cloud.speech.client import Client

from google.cloud.speech.client import Encoding

This comment was marked as spam.

Sign in to view

tseaver reviewed Oct 6, 2016

View reviewed changes

Add Sample factory to Client.

04bf28d

daspecster force-pushed the cleanup-speech branch from f14c72e to 04bf28d Compare October 6, 2016 18:20

tseaver approved these changes Oct 6, 2016

View reviewed changes

daspecster merged commit fb10016 into googleapis:master Oct 6, 2016

daspecster deleted the cleanup-speech branch October 6, 2016 19:28

daspecster mentioned this pull request Oct 6, 2016

Add Speech Streaming usage documentation. #2483

Closed

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017

Merge pull request googleapis#2495 from daspecster/cleanup-speech

db307dc

Updates from googleapis#2344 for speech API.

theacodes unassigned dhermes Sep 28, 2018

Conversation

daspecster commented Oct 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

daspecster commented Oct 5, 2016

Uh oh!

daspecster commented Oct 5, 2016

Uh oh!

daspecster commented Oct 6, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 6, 2016

Uh oh!

tseaver left a comment

Choose a reason for hiding this comment

Uh oh!

daspecster commented Oct 6, 2016

Uh oh!

daspecster commented Oct 6, 2016

Uh oh!

daspecster commented Oct 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants