Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

The ServiceObject was previously expecting precise arguments to a createSomething() callback:

service.createServiceObject(function(err, createdServiceObject, apiResponse) {});

That is almost always correct, except in the case of Compute Engine, which returns:

compute.createServiceObject(function(err, createdServiceObject, operation, apiResponse) {});

This updates the generic "create" method to consider that scenario.

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. core labels Nov 11, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2015
@stephenplusplus stephenplusplus force-pushed the spp--ServiceObject-create-fix branch from ad30f84 to 2396a66 Compare November 11, 2015 20:25
callmehiphop added a commit that referenced this pull request Nov 11, 2015
…e-fix

core: serviceobject#create: pass through any amount of arguments
@callmehiphop callmehiphop merged commit c0ffbde into googleapis:master Nov 11, 2015
sofisl pushed a commit that referenced this pull request Nov 11, 2022
… type (#938)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 437265289

Source-Link: googleapis/googleapis@8e6b72f

Source-Link: googleapis/googleapis-gen@318cde2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzE4Y2RlMmVlM2JmZDViNDRhY2RmMWY2ZTI1YjhlMGE2NjZmMDc2NCJ9
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-datastore).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants