-
Notifications
You must be signed in to change notification settings - Fork 641
Add Google Cloud DNS #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud DNS #706
Conversation
system-test/dns.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
e964fe8 to
bc19a17
Compare
d6348d9 to
c42fdfb
Compare
|
Assigned to @callmehiphop for a review, please. Probably easiest to start with the docs, and make sure the API looks sane. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jgeewax Since we're trapped on what we can do with system testing (re: the error
It's not exactly pretty to make our tests run like that, but it's possible. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I can't find anywhere in any of my projects that have a zone for gcloud-node.com ... I opened a ticket asking WTF is going on... because that's super weird. If you know a project that has the zone created... lmk... I'd really like to use gcloud-node as the demo domain... |
lib/dns/zone.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5b03461e-47c0-40e8-a8ad-c465ee146cc5/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@388e10f Source-Link: googleapis/synthtool@d82decc Source-Link: googleapis/synthtool@799d8e6
* build!: Update library to use Node 12 Co-authored-by: Summer Ji <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Fixes #486
To Dos
GCLOUD_TESTS_DNS_DOMAINenv var to travis (value:gcloud-node.com.)Docs: https://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/docs/master/dns