storage: add download() method by stephenplusplus · Pull Request #381 · googleapis/google-cloud-node

stephenplusplus · 2015-02-04T19:48:33Z

Fixes #367

Adds a download method to a File object:

// Getting the contents of a file.
file.download(function(err, contents) {})
file.download({ start: 0, end: 100 }, function(err, contents) {});

// Writing the file to a local destination
file.download({ destination: '/Users/stephen/file.txt' }, function(err) {});
file.download({ start: 0, end: 100, destination: '/Users/stephen/file.txt' }, function(err) {});

This method just blankets file.createReadStream(options), so the options passed to download are passed up to createReadStream.

lib/storage/file.js

+      .on('error', callback)
+      .on('finish', callback);
+  } else {
+    var fileContents = new Buffer('');


ryanseys · 2015-02-09T15:37:45Z

Will require a rebase

stephenplusplus · 2015-02-09T19:35:38Z

Using the new once module + rebased.

storage: add download() method

ryanseys · 2015-02-09T20:05:39Z

LGTM! :) 🚢

…ed existing docs. (#381) Clients receive detailed OutputResult in ExportAssetsResponse. PiperOrigin-RevId: 326582222 Source-Author: Google APIs <noreply@google.com> Source-Date: Thu Aug 13 20:45:57 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 3a54e988edcbdef1e47c6ac19d3074a87214f667 Source-Link: googleapis/googleapis@3a54e98

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [null-loader](https://togithub.com/webpack-contrib/null-loader) | devDependencies | major | [`^3.0.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/null-loader/3.0.0/4.0.0) | --- ### Release Notes <details> <summary>webpack-contrib/null-loader</summary> ### [`v4.0.0`](https://togithub.com/webpack-contrib/null-loader/blob/master/CHANGELOG.md#400-httpsgithubcomwebpack-contribnull-loadercomparev300v400-2020-04-15) [Compare Source](https://togithub.com/webpack-contrib/null-loader/compare/v3.0.0...v4.0.0) ##### Bug Fixes - support `webpack@5` ##### ⚠ BREAKING CHANGES - minimum required Nodejs version is `10.13` </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-redis).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-language/compare/v3.7.2...v3.8.0) (2020-02-28) ### Features * export protos in src/index.ts ([482fb10](https://www.github.com/googleapis/nodejs-language/commit/482fb10bc1d4f01bd3de38a0301cda2a2efb491d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-phishing-protection).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.8.0](https://www.github.com/googleapis/nodejs-language/compare/v3.7.2...v3.8.0) (2020-02-28) ### Features * export protos in src/index.ts ([482fb10](https://www.github.com/googleapis/nodejs-language/commit/482fb10bc1d4f01bd3de38a0301cda2a2efb491d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

…381) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/a8ab5675-1982-4cf5-b9b7-36794038b975/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@8cf6d28

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2015

stephenplusplus force-pushed the spp--storage-download branch from 799d4bf to baae93f Compare February 4, 2015 19:49

stephenplusplus mentioned this pull request Feb 4, 2015

add download() method #367

Closed

ryanseys reviewed Feb 5, 2015
View reviewed changes

ryanseys mentioned this pull request Feb 5, 2015

Release 0.13.0? #382

Closed

stephenplusplus force-pushed the spp--storage-download branch from baae93f to 51d71c1 Compare February 5, 2015 20:17

storage: add download() method

132150c

stephenplusplus force-pushed the spp--storage-download branch from 47b69b3 to 132150c Compare February 9, 2015 19:34

ryanseys added a commit that referenced this pull request Feb 9, 2015

Merge pull request #381 from stephenplusplus/spp--storage-download

b52b28b

storage: add download() method

ryanseys merged commit b52b28b into googleapis:master Feb 9, 2015

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

4 tasks

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix(docs): snippets are now replaced in jsdoc comments (#381)

4d8b647

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-container #3543

Merged

4 tasks

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-iot #3544

Merged

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore: remove tslint.json (#381)

b88dc1a

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore: npm-install-retry is not a thing anymore (#381)

21ac129

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

fix(docs): link to reference docs section on googleapis.dev (#381)

de6c5a0

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

fix(docs): link to reference docs section on googleapis.dev (#381)

03f7abc

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

sofisl mentioned this pull request Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7043

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Jan 27, 2026

fix: use NAN from github to fix v8 canary e2e test (#381)

b0122a9

This was referenced Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7044

Closed

migrate code from googleapis/cloud-profiler-nodejs #7045

Closed

migrate code from googleapis/cloud-profiler-nodejs #7046

Closed

sofisl pushed a commit that referenced this pull request Jan 27, 2026

fix: use NAN from github to fix v8 canary e2e test (#381)

1aa3b47

This was referenced Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7047

Closed

migrate code from googleapis/cloud-profiler-nodejs #7048

Closed

migrate code from googleapis/cloud-profiler-nodejs #7049

Closed

migrate code from googleapis/cloud-profiler-nodejs #7051

Closed

sofisl pushed a commit that referenced this pull request Jan 28, 2026

fix: use NAN from github to fix v8 canary e2e test (#381)

35e52ef

sofisl pushed a commit that referenced this pull request Feb 3, 2026

docs(samples): adds queryParamsNamed and queryParamsPositional (#381)

57f04b5

sofisl mentioned this pull request Feb 3, 2026

migrate code from googleapis/nodejs-bigquery #7111

Merged

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

fix(docs): link to reference docs section on googleapis.dev (#381)

93530d3

* fix(docs): reference docs should link to section of googleapis.dev with API reference * fix(docs): make anchors work in jsdoc

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: add download() method#381

storage: add download() method#381
ryanseys merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--storage-download

stephenplusplus commented Feb 4, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Feb 9, 2015

Uh oh!

stephenplusplus commented Feb 9, 2015

Uh oh!

ryanseys commented Feb 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

stephenplusplus commented Feb 4, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Feb 9, 2015

Uh oh!

stephenplusplus commented Feb 9, 2015

Uh oh!

ryanseys commented Feb 9, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments