improve coverage #334

stephenplusplus · 2014-12-16T21:40:13Z

Fixes #333
It's not a pretty diff, but it will put us back in the green.

package.json

ryanseys · 2014-12-22T16:18:48Z

Review complete. Please fix issues then I'll take another look.

stephenplusplus · 2014-12-22T17:42:08Z

Added the .end()s, removed power-assert, and squashed.

package.json

ryanseys · 2014-12-22T21:32:35Z

LGTM. Make it rain (code coverage)!

improve coverage

stephenplusplus · 2014-12-22T23:06:25Z

Woo! Can't wait to see all the tweets about our code coverage badge going up 13%.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets

…d config for cloud-rad for nodejs (#334) * build: missing closing paren in publish script Source-Author: Benjamin E. Coe <[email protected]> Source-Date: Mon Jul 13 09:56:30 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: d82deccf657a66e31bd5da9efdb96c6fa322fc7e Source-Link: googleapis/synthtool@d82decc * chore: delete template for Node 8 tests Source-Author: F. Hinkelmann <[email protected]> Source-Date: Tue Jul 14 19:56:02 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 388e10f5ae302d3e8de1fac99f3a95d1ab8f824a Source-Link: googleapis/synthtool@388e10f * chore: add config files for cloud-rad for node.js * chore: add config files for cloud-rad for node.js Generate and upload yaml files for ref docs * Add gitattributes for json with comments * Fix extra char Source-Author: F. Hinkelmann <[email protected]> Source-Date: Thu Jul 16 12:19:00 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 21f1470ecd01424dc91c70f1a7c798e4e87d1eec Source-Link: googleapis/synthtool@21f1470

🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.7](https://www.github.com/googleapis/nodejs-phishing-protection/compare/v2.4.6...v2.4.7) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#333](https://www.github.com/googleapis/nodejs-phishing-protection/issues/333)) ([60f816a](https://www.github.com/googleapis/nodejs-phishing-protection/commit/60f816a42aa198aa36ddeceee49ca38553fddb4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/c70654a6-9134-4d1e-9028-96354fef7186/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@89c849b Source-Link: googleapis/synthtool@a783321 Source-Link: googleapis/synthtool@b7413d3 Source-Link: googleapis/synthtool@5f6ef0e

Co-authored-by: Steffany Brown <[email protected]>

chore(deps): update dependency nyc to v14 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | nyc | devDependencies | major | [`^13.0.0` -> `^14.0.0`](https://diff.intrinsic.com/nyc/13.3.0/14.0.0) | [source](https://togithub.com/istanbuljs/nyc) | --- ### Release Notes <details> <summary>istanbuljs/nyc</summary> ### [`v14.0.0`](https://togithub.com/istanbuljs/nyc/blob/master/CHANGELOG.md#1400httpsgithubcomistanbuljsnyccomparev1330v1400-2019-04-15) [Compare Source](https://togithub.com/istanbuljs/nyc/compare/v13.3.0...v14.0.0) ##### Bug Fixes - Add `cwd` option to instrument command ([#1024](https://togithub.com/istanbuljs/nyc/issues/1024)) ([051d95a](https://togithub.com/istanbuljs/nyc/commit/051d95a)) - Add config values to hash salt ([#988](https://togithub.com/istanbuljs/nyc/issues/988)) ([7ac325d](https://togithub.com/istanbuljs/nyc/commit/7ac325d)), closes [#522](https://togithub.com/istanbuljs/nyc/issues/522) - Exclude negated not working with '--all' switch ([#977](https://togithub.com/istanbuljs/nyc/issues/977)) ([91de23c](https://togithub.com/istanbuljs/nyc/commit/91de23c)) - Make --all work for transpiled code ([#1047](https://togithub.com/istanbuljs/nyc/issues/1047)) ([18e04ba](https://togithub.com/istanbuljs/nyc/commit/18e04ba)) - Resolve absolute paths in nyc instrument ([#1012](https://togithub.com/istanbuljs/nyc/issues/1012)) ([3cb1861](https://togithub.com/istanbuljs/nyc/commit/3cb1861)), closes [#1014](https://togithub.com/istanbuljs/nyc/issues/1014) - Set processinfo pid/ppid to actual numbers ([#1057](https://togithub.com/istanbuljs/nyc/issues/1057)) ([32f75b0](https://togithub.com/istanbuljs/nyc/commit/32f75b0)) - Use a single instance of nyc for all actions of main command. ([#1059](https://togithub.com/istanbuljs/nyc/issues/1059)) ([b909575](https://togithub.com/istanbuljs/nyc/commit/b909575)) ##### Features - Add `delete` option to instrument command ([#1005](https://togithub.com/istanbuljs/nyc/issues/1005)) ([d6db551](https://togithub.com/istanbuljs/nyc/commit/d6db551)) - Add `include` and `exclude` options to instrument command ([#1007](https://togithub.com/istanbuljs/nyc/issues/1007)) ([8da097e](https://togithub.com/istanbuljs/nyc/commit/8da097e)) - Add processinfo index, add externalId ([#1055](https://togithub.com/istanbuljs/nyc/issues/1055)) ([8dcf180](https://togithub.com/istanbuljs/nyc/commit/8dcf180)) - Add support for nyc.config.js ([#1019](https://togithub.com/istanbuljs/nyc/issues/1019)) ([3b203c7](https://togithub.com/istanbuljs/nyc/commit/3b203c7)) - Add support to exclude files on coverage report generation ([#982](https://togithub.com/istanbuljs/nyc/issues/982)) ([509c6aa](https://togithub.com/istanbuljs/nyc/commit/509c6aa)) - Add test-exclude args to check-coverage and report subcommands. ([0fc217e](https://togithub.com/istanbuljs/nyc/commit/0fc217e)) - Always build the processinfo temp dir ([#1061](https://togithub.com/istanbuljs/nyc/issues/1061)) ([c213469](https://togithub.com/istanbuljs/nyc/commit/c213469)) - Enable `es-modules` option for nyc instrument command ([#1006](https://togithub.com/istanbuljs/nyc/issues/1006)) ([596b120](https://togithub.com/istanbuljs/nyc/commit/596b120)) - Fix excludeAfterRemap functionality. ([36bcc0b](https://togithub.com/istanbuljs/nyc/commit/36bcc0b)) - Implement `nyc instrument --complete-copy` ([#1056](https://togithub.com/istanbuljs/nyc/issues/1056)) ([2eb13c6](https://togithub.com/istanbuljs/nyc/commit/2eb13c6)) - Remove bundling ([#1017](https://togithub.com/istanbuljs/nyc/issues/1017)) ([b25492a](https://togithub.com/istanbuljs/nyc/commit/b25492a)) - Support turning off node_modules default exclude via `exclude-node-modules` option ([#912](https://togithub.com/istanbuljs/nyc/issues/912)) ([b7e16cd](https://togithub.com/istanbuljs/nyc/commit/b7e16cd)) - Add support for `--exclude-node-modules` to subcommands. ([#1053](https://togithub.com/istanbuljs/nyc/issues/1053)) ([e597c46](https://togithub.com/istanbuljs/nyc/commit/e597c46)) ##### BREAKING CHANGES - The `--exclude-after-remap` option is now functional and enabled by default. This causes the `include` and `exclude` lists to be processed after using source maps to determine the original filename of sources. - Add a file named 'index.json' to the .nyc_output/processinfo directory, which has a different format from the other files in this dir. - Change the data type of the pid/ppid fields in processinfo files - `nyc instrument` now honors `include` and `exclude` settings, potentially resulting in some files that were previously instrumented being ignored. - The `plugins` option has been renamed to `parser-plugins`. - The logic involving include/exclude processing has changed. Results should be verified to ensure all desired sources have coverage data. - `nyc instrument` now enables the `--es-module` option by default. This can cause failures to instrument scripts which violate `'use strict'` rules. </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-speech). #334 automerged by dpebot

…s directly from the library (#334) * chore: call non-hermetic functions since we're installing node_modules directly from the library Source-Link: googleapis/synthtool@4c4063f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:8b6a07a38d1583d96b6e251ba208bd4ef0bc2a0cc37471ffc518841651d15bd6 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

stephenplusplus changed the title ~~Spp improve coverage~~ improve coverage Dec 16, 2014

stephenplusplus reviewed Dec 17, 2014
View reviewed changes

package.json Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ryanseys mentioned this pull request Dec 22, 2014

tests: Clean up instance object names that are the same as the class they instance from. #338

Closed

tests: use mockery

e24fa50

stephenplusplus force-pushed the spp--improve-coverage branch from f83a411 to e24fa50 Compare December 22, 2014 17:41

stephenplusplus reviewed Dec 22, 2014
View reviewed changes

package.json

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus added a commit that referenced this pull request Dec 22, 2014

Merge pull request #334 from stephenplusplus/spp--improve-coverage

b7ac20e

improve coverage

stephenplusplus merged commit b7ac20e into googleapis:master Dec 22, 2014

ace-n mentioned this pull request Apr 5, 2017

spanner: how should transactional promises look? #2152

Closed

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

build: update protos.js (#334)

7c5f3c2

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/041f5df7-f5d3-4b2a-9ede-0752bf41c185/targets

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore: remove unused dev packages (#334)

aa4c76a

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: remove unused dev packages (#334)

a991828

sofisl mentioned this pull request Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore: remove unused dev packages (#334)

3b9e6e4

sofisl mentioned this pull request Oct 8, 2022

migrate code from googleapis/nodejs-os-login #3389

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore: remove unused dev packages (#334)

562e8d2

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

4 tasks

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.1.1 (#334)

5e75d21

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl mentioned this pull request Nov 30, 2022

migrate code from googleapis/nodejs-datacatalog #3689

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 30, 2022

chore(deps): update dependency sinon to v13 (#334)

ce4caef

Co-authored-by: Steffany Brown <[email protected]>

sofisl mentioned this pull request Jan 17, 2023

migrate code from googleapis/nodejs-vision #3860

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 17, 2023

fix: throw on invalid credentials in v1p4beta1 (#334)

d3cdc34

sofisl mentioned this pull request Sep 13, 2023

migrate code from googleapis/nodejs-automl #4655

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 13, 2023

chore(deps): update dependency uuid to v7 (#334)

8ffc1b6

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-automl #4656

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 14, 2023

chore(deps): update dependency mocha to v7 (#334)

65d00ab

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

takeratta mentioned this pull request Dec 14, 2023

[Snyk] Fix for 1 vulnerabilities takeratta/google-cloud-node#53

Open

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore: system tests for gax (#334)

edb9ad8

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6991

Closed

miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026

build: switch to GitHub magic proxy (#334)

abe23b0

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6995

Closed

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

fix(deps): update dependency @google-cloud/common to ^0.32.0 (#334)

b5bd04d

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

fix(deps): update dependency @google-cloud/common to ^0.32.0 (#334)

2a2258f

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026

build: switch to GitHub magic proxy (#334)

1013b49

miguelvelezsa mentioned this pull request Jan 21, 2026

migrate code from googleapis/nodejs-logging-bunyan #7021

Open

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

docs: update links in contrib guide (#334)

aeccd38

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Open

miguelvelezsa mentioned this pull request Jan 29, 2026

migrate code from googleapis/nodejs-promisify #7059

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve coverage #334

improve coverage #334

Uh oh!

stephenplusplus commented Dec 16, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Dec 22, 2014

Uh oh!

stephenplusplus commented Dec 22, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Dec 22, 2014

Uh oh!

stephenplusplus commented Dec 22, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

improve coverage #334

improve coverage #334

Uh oh!

Conversation

stephenplusplus commented Dec 16, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Dec 22, 2014

Uh oh!

stephenplusplus commented Dec 22, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Dec 22, 2014

Uh oh!

stephenplusplus commented Dec 22, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants