Merged
Conversation
regression/datastore.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
There are more issues, but we need to remove globals like |
* Coverage for datastore.
Contributor
Author
|
@rakyll first bunch of review comments should be covered. |
regression/datastore.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Added some comments. Otherwise, LGTM. |
Contributor
Author
|
@rakyll that test should be better now :) |
Contributor
|
Yes, look good. Merging. |
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
PiperOrigin-RevId: 315786558 Source-Author: Google APIs <[email protected]> Source-Date: Wed Jun 10 15:57:14 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 81226871ce438cdeec241dd81f33f796e37e1c03 Source-Link: googleapis/googleapis@8122687 Co-authored-by: Justin Beckwith <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
* fix: flag module as GA * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .repo-metadata.json * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.5](https://www.github.com/googleapis/nodejs-cloud-shell/compare/v1.0.4...v1.0.5) (2021-08-30) ### Bug Fixes * flag module as GA ([#33](https://www.github.com/googleapis/nodejs-cloud-shell/issues/33)) ([cf357c8](https://www.github.com/googleapis/nodejs-cloud-shell/commit/cf357c81140d75b3c7106dc747bac328da247363)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
Coverage reporting regressed by #29 which added build/ to nyc.exclude configuration.
This was referenced Jan 27, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
This was referenced Jan 29, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Samples: rewrite simple app tutorial. - Add additional region tags to support tutorial rewrite. - Use more direct map for printing results. - Use more relevant query from public datasets.
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 4, 2026
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently coverings for datastore.
@rakyll if the approach is ok I'll add to the README instructions on how to run the tests (basically configuring the export variables in run_regression_tests.sh) and I will add the tests to our build.