fix: return correct buffer object for datastore responses #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanseys
changed the title
ryanseys
changed the title
Contributor
Author
|
Should be ready for a code review. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM 👍 |
stephenplusplus
added a commit
that referenced
this pull request
Nov 17, 2014
fix: return correct buffer object for datastore responses
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@types/sinon](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | devDependencies | major | [`^7.5.2` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fsinon/7.5.2/9.0.0) | --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-asset).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
* feat: expose getIamPolicy for Project Object
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-resource/compare/v1.1.5...v1.2.0) (2020-05-20) ### Features * Expose getIamPolicy support for project ([#302](https://www.github.com/googleapis/nodejs-resource/issues/302)) ([85f136d](https://www.github.com/googleapis/nodejs-resource/commit/85f136dfe133e42976864082cfe444a3f0cea37c)) ### Bug Fixes * apache license URL ([#468](https://www.github.com/googleapis/nodejs-resource/issues/468)) ([#308](https://www.github.com/googleapis/nodejs-resource/issues/308)) ([3fdebd3](https://www.github.com/googleapis/nodejs-resource/commit/3fdebd3b5f57d11dc77b8a6755d25d9be3da4794)) * **deps:** update dependency @google-cloud/common to v3 ([#301](https://www.github.com/googleapis/nodejs-resource/issues/301)) ([0ee3bf1](https://www.github.com/googleapis/nodejs-resource/commit/0ee3bf19810f38c4aa2a4e1b389022bc32bc70bc)) * **deps:** update dependency @google-cloud/paginator to v3 ([#299](https://www.github.com/googleapis/nodejs-resource/issues/299)) ([3cffb9f](https://www.github.com/googleapis/nodejs-resource/commit/3cffb9ffbdeaabd77522f17af9b5f25eb11a9009)) * **deps:** update dependency @google-cloud/promisify to v2 ([#298](https://www.github.com/googleapis/nodejs-resource/issues/298)) ([1e8965f](https://www.github.com/googleapis/nodejs-resource/commit/1e8965f204195d7d0014691dad6eb7d2efb632b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
4 tasks
This was referenced Oct 27, 2023
Open
This was referenced Dec 14, 2023
Open
This was referenced Jan 2, 2024
Open
Open
This was referenced Mar 15, 2024
Open
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
docs: use https for links
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
docs: use https for links
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
docs: use https for links
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-promisify).
](https://renovatebot.com){kind=link}
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
docs: use https for links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the raw buffer object for
blob_valuerather than the ByteBuffer object when decoding a datastore response.This fixes #301.