docs(contributing): document git commit conventions #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
force-pushed
the
commit-guidelines
branch
from
e8ae9ba to
ecefd46
Compare
Contributor
|
Does every commit require a body and footer? |
Contributor
|
As per the guidelines your commit should be docs(contrib): ... or docs(contributing): ... As docs() and chore() are separate 😄 |
To introduce contributors to our git conventions, our CONTRIBUTING.md file now links to the AngularJS contributing document.
stephenplusplus
force-pushed
the
commit-guidelines
branch
from
ecefd46 to
cf2cb45
Compare
Contributor
Author
|
Yikes, I should probably read the guide sometime. |
Contributor
Author
Body - yes, footer - maybe. Up to interpretation, perhaps. The footer is where breaking changes and relevant issues are attached. If there are none, I suppose there isn't anything to put there. Going to merge. If we want, we can add/elaborate later. |
stephenplusplus
added a commit
that referenced
this pull request
Sep 18, 2014
docs(contributing): document git commit conventions
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
changed the title
stephenplusplus
added a commit
that referenced
this pull request
Sep 18, 2014
Eliminate potential confusion caused by referring to the AngularJS repo. We also prefer the use of a `common` scope over `app` for library-wide changes. Resolves #224
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
fix: improve docstrings, and add more field validation
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
fix: improve docstrings, and add more field validation
This was referenced Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
PiperOrigin-RevId: 423128259 Source-Link: googleapis/googleapis@86c3294 Source-Link: googleapis/googleapis-gen@60e75b8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjBlNzViODgyYWE0OGNiNzVjODNkOTRhOWUzYTIwYzk5NjM2Y2FmMCJ9 See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
sofisl
added a commit
that referenced
this pull request
Nov 16, 2022
samples: pull in latest typeless bot, clean up some comments Source-Link: googleapis/synthtool@0a68e56 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 27, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/c36c6dbc-ab79-4f17-b70b-523b420b2a70/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To introduce contributors to our git conventions, our CONTRIBUTING.md
file now links to the AngularJS contributing document.