-
Notifications
You must be signed in to change notification settings - Fork 641
Change heading colors in generated API docs to make them stand out. #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is just an example.
|
Now at least I know what "Lock pull request" might do. This PR has two very distinct changes in it. |
|
I like the heading color change 👍 But, the "Quick, take me" link feels a little out of place to me. What about just something like this: https://github.com/stephenplusplus/gcloud-node/blob/quick-link/README.md ? |
|
Yes, that is much much better. Thanks. |
|
I reverted the README part of this PR. |
|
Merged via 13b53c1. |
Discussed in #192 Also, Quickstart -> Quick Start
|
As @silvolu pointed out off line, it is many years since I used Github and wrote code. |
* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* add node in profile to track external memory * add node to v8 profile to add (external) node to profile * address comments * add external heap node in heap-profiler.ts
* add node in profile to track external memory * add node to v8 profile to add (external) node to profile * address comments * add external heap node in heap-profiler.ts
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip] Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* build: fix codecov uploading on Kokoro * build: fix codecov uploading on Kokoro
This is just an example.