Skip to content

Nit. They are words (adverbs), but they don't work so well here. #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcgel wants to merge 1 commit into from
Closed

Nit. They are words (adverbs), but they don't work so well here. #187

marcgel wants to merge 1 commit into from

Conversation

@marcgel
Copy link
Contributor

@marcgel marcgel commented Sep 5, 2014

No description provided.

@rakyll
Copy link
Contributor

rakyll commented Sep 5, 2014

Lint the code. npm run lint. Lint is failing with lib/datastore/query.js: line 130, col 84, Line is too long.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Sep 6, 2014

Merged via 3c875a9.

@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@callmehiphop
build: switch to GitHub magic proxy (#187)
87965f5
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
8401659
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
ebfbda8
@sofisl sofisl mentioned this pull request Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
30991ec
@sofisl sofisl mentioned this pull request Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@yoshi-automation @JustinBeckwith
build: only pipe to codecov if tests run on Node 10 (#187)
48f3f00
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@jkwlui
build: check broken links in generated docs (#187)
1ed95f8 
* build: check dead links on Kokoro

* recursive crawl local links
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@jmdobry
Refactor old BigQuery samples and add new ones. (#187)
d6d5fba
sofisl pushed a commit that referenced this pull request Oct 12, 2022
@JustinBeckwith @jkwlui
Release v0.9.1 (#187)
4f569c1
@sofisl sofisl mentioned this pull request Oct 12, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@jkwlui @sofisl
build: check broken links in generated docs (#187)
f5a97a7 
* build: check dead links on Kokoro

* recursive crawl local links
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@jkwlui
Release v2.1.3 (#187)
d8a1eca
This was referenced Nov 10, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@renovate @callmehiphop
fix(deps): update dependency yargs to v13 (#187)
890a042
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@JustinBeckwith @yoshi-automation
refactor: use execSync for tests
d2e60d6 
refactor: use execSync for tests

#187 automerged by dpebot
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
chore: regenerate synth.metadata (#187)
4428600
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
docs: add link to CHANGELOG in README (#187)
86ed40c
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
feat: move ts target to es2018 from es2016 (#187)
e317a96 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9b55eba7-85ee-48d5-a737-8b677439db4d/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1c92077
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
@takeratta takeratta mentioned this pull request Mar 22, 2024
Open
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
@greenkeeper @alexander-fenster
fix(package): update globby to version 8.0.0 (#187)
6ab86c0
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@DominicKramer
chore: do not target es5 (#187)
189b144 
Targeting `es5` caused the koa plugin, which is a generator
function, to be transpiled into a regular function.  As a result,
Koa@1 would refuse to use the plugin.
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@soldair
test: increasing error_reporting poll timeout for system tests (#187)
6f90cc3
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
@DominicKramer
chore: do not target es5 (#187)
6060b10 
Targeting `es5` caused the koa plugin, which is a generator
function, to be transpiled into a regular function.  As a result,
Koa@1 would refuse to use the plugin.
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
@soldair
test: increasing error_reporting poll timeout for system tests (#187)
b3e5998
@GautamSharda GautamSharda mentioned this pull request Jan 20, 2026
Closed
4 tasks
GautamSharda pushed a commit that referenced this pull request Jan 21, 2026
@soldair
test: increasing error_reporting poll timeout for system tests (#187)
a53c556
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
@sofisl sofisl mentioned this pull request Jan 27, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@JustinBeckwith @nolanmar511
fix: upgrade to the latest @google-cloud/common (#187)
e2a0e6b 
* fix: upgrade to the latest @google-cloud/common

* pr feedback

* update deps

* 🙄
This was referenced Jan 27, 2026
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@JustinBeckwith @nolanmar511
fix: upgrade to the latest @google-cloud/common (#187)
9f60f1f 
* fix: upgrade to the latest @google-cloud/common

* pr feedback

* update deps

* 🙄
This was referenced Jan 27, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
GautamSharda pushed a commit that referenced this pull request Feb 2, 2026
@soldair
test: increasing error_reporting poll timeout for system tests (#187)
2434abb
@GautamSharda GautamSharda mentioned this pull request Feb 2, 2026
Open
@sofisl sofisl mentioned this pull request Feb 3, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcgel @rakyll @stephenplusplus