datastore: properly form deferred keys#1498
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Aug 22, 2016
Merged
datastore: properly form deferred keys#1498stephenplusplus merged 1 commit intogoogleapis:masterfrom
stephenplusplus merged 1 commit intogoogleapis:masterfrom
Conversation
Contributor
Author
|
@sfbaltaci -- would you mind trying this out? $ npm install --save stephenplusplus/gcloud-node#spp--1497 |
|
sure, i just have a problem when trying to install your branch. |
Contributor
Author
|
Woops, sorry. I forgot with the new restructured repo, it's not a one-liner to install from a PR branch anymore. The most straightforward way to try it out is by cloning: $ git clone https://github.com/stephenplusplus/gcloud-node -b spp--1497
$ cd gcloud-node/packages/compute
$ npm install
$ npm link
# cd to your project
$ npm link @google-cloud/computeWhere you're using Compute: -var compute = gcloud.compute();
+var compute = require('@google-cloud/compute')();Sorry for that being so complicated :\ |
|
It works !! |
Contributor
Author
|
Awesome, thanks for reporting and testing! @callmehiphop PTAL |
stephenplusplus
added a commit
to stephenplusplus/gcloud-node
that referenced
this pull request
Aug 23, 2016
stephenplusplus
added a commit
to stephenplusplus/gcloud-node
that referenced
this pull request
Aug 23, 2016
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1497
Keys need to be properly formed for the API. We were skipping a step with deferred keys.