Skip to content

datastore: properly form deferred keys#1498

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--1497
Aug 22, 2016
Merged

datastore: properly form deferred keys#1498
stephenplusplus merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--1497

Conversation

@stephenplusplus
Copy link
Contributor

Fixes #1497

Keys need to be properly formed for the API. We were skipping a step with deferred keys.

@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label Aug 16, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2016
@stephenplusplus
Copy link
Contributor Author

@sfbaltaci -- would you mind trying this out?

$ npm install --save stephenplusplus/gcloud-node#spp--1497

@5o50
Copy link

5o50 commented Aug 16, 2016

sure, i just have a problem when trying to install your branch.
I updated npm and stuff

 👉  npm install --save stephenplusplus/gcloud-node#spp--1497
npm ERR! addLocal Could not install /var/folders/0_/48d676fd5tldy0mjv1dxkbyc0000gn/T/npm-66124-83f10e85/git-cache-29227a15/67ccd9a66251327cc5acfd20a411c120c1055b6c
npm ERR! addLocal Could not install /var/folders/0_/48d676fd5tldy0mjv1dxkbyc0000gn/T/npm-66124-83f10e85/git-cache-53ed583b/67ccd9a66251327cc5acfd20a411c120c1055b6c
npm ERR! addLocal Could not install /var/folders/0_/48d676fd5tldy0mjv1dxkbyc0000gn/T/npm-66124-83f10e85/git-cache-76ceb629/67ccd9a66251327cc5acfd20a411c120c1055b6c
npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node/6.3.1/bin/node" "/usr/local/bin/npm" "install" "--save" "stephenplusplus/gcloud-node#spp--1497"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.6

npm ERR! No version provided in package.json
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/baltaci/Desktop/api-svc/npm-debug.log

@stephenplusplus
Copy link
Contributor Author

Woops, sorry. I forgot with the new restructured repo, it's not a one-liner to install from a PR branch anymore. The most straightforward way to try it out is by cloning:

$ git clone https://github.com/stephenplusplus/gcloud-node -b spp--1497
$ cd gcloud-node/packages/compute
$ npm install
$ npm link

# cd to your project
$ npm link @google-cloud/compute

Where you're using Compute:

-var compute = gcloud.compute();
+var compute = require('@google-cloud/compute')();

Sorry for that being so complicated :\

@5o50
Copy link

5o50 commented Aug 16, 2016

It works !!
Thanks for your reactivity 💯

[nodemon] starting `node server.js`
info: api-svc ✓ PORT: 3000 PID: 69190 NODE_ENV: staging
INPUT 318
318 RESULTS
info: POST /graphql? 200 5002ms

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 67ccd9a on stephenplusplus:spp--1497 into 3cfc68c on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor Author

Awesome, thanks for reporting and testing!

@callmehiphop PTAL

@stephenplusplus stephenplusplus merged commit 998cef3 into googleapis:master Aug 22, 2016
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this pull request Aug 23, 2016
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this pull request Aug 23, 2016
sofisl pushed a commit that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants