Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus
Copy link
Contributor Author

Let me know if/when this is merge-worthy, and I'll do a rebase and rebuild of the docs so we're current.

@silvolu
Copy link
Contributor

silvolu commented Aug 26, 2014

Oh, I thought it was still WIP from the commit message :)

Looks good to me, please go forward. I'll then make some tweaks that we'll discuss later!

@stephenplusplus stephenplusplus force-pushed the docs branch 2 times, most recently from cc6dfcc to d27dfad Compare August 26, 2014 17:21
@stephenplusplus
Copy link
Contributor Author

Re-built :)

@rakyll
Copy link
Contributor

rakyll commented Aug 26, 2014

Is it possible to remove TODOs and private types/members/methods from docs? We should generate docs only for user-facing stuff.

@stephenplusplus
Copy link
Contributor Author

Poll time! Do you think the docs should be:

var dataset = new Dataset(){};

or a real use case:

var gcloud = require('gcloud');
var dataset = new gcloud.datastore.Dataset({});

?

@silvolu
Copy link
Contributor

silvolu commented Aug 26, 2014

I vote real use case.

@rakyll
Copy link
Contributor

rakyll commented Aug 26, 2014

I vote for the real use case too. Maybe we don't need to mention var gcloud = require('gcloud') each time.

@stephenplusplus
Copy link
Contributor Author

Holy moly, the big PR is updated! http://stephenplusplus.github.io/gcloud-node/ for a preview.

@stephenplusplus stephenplusplus changed the title docs: jsdoc + jsdoc2md + travis auto build to gh-pages. docs: jsdoc + travis auto build to gh-pages. Aug 27, 2014
@rakyll
Copy link
Contributor

rakyll commented Aug 27, 2014

Looks great!

@silvolu
Copy link
Contributor

silvolu commented Aug 27, 2014

Great, thanks!

silvolu added a commit that referenced this pull request Aug 27, 2014
docs: jsdoc + travis auto build to gh-pages.
@silvolu silvolu merged commit adb85ad into googleapis:master Aug 27, 2014
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
sofisl pushed a commit that referenced this pull request Sep 15, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026
There is an issue with [email protected] with the included types.  This
is being tracked at delay
[issue #32](sindresorhus/delay#32) and
is preventing @google-cloud/logging-bunyan from compiling.

Until delay issue #32 is resolved, delay will be pinned to version
3.0.x.
sofisl pushed a commit that referenced this pull request Jan 27, 2026
sofisl pushed a commit that referenced this pull request Jan 27, 2026
miguelvelezsa pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants