datastore: fixing a query limit bug#1251
Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom Apr 21, 2016
callmehiphop:query-limit-bug
Merged
datastore: fixing a query limit bug#1251stephenplusplus merged 1 commit intogoogleapis:masterfrom callmehiphop:query-limit-bug
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:query-limit-bug
Conversation
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
Contributor
|
LGTM. Is there a test case we can add to cover the situation caused in #1249? |
Contributor
Author
|
@stephenplusplus I think this would obviously be difficult for us to reproduce via e2e tests, so I'll write a unit test. |
Contributor
Author
|
@stephenplusplus PTAL! |
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
…ration (#1251) * feat: New PropertyMask field which allows partial commits, lookups, and query results PiperOrigin-RevId: 635449160 Source-Link: googleapis/googleapis@dde0ec1 Source-Link: googleapis/googleapis-gen@8caa60d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGNhYTYwZDlhZWE4Mjk2NGExOWNkZjhmYWY5MTM4NDkxMWRiOGJkZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: update gapic generator to allow individual location mixin generation PiperOrigin-RevId: 638462084 Source-Link: googleapis/googleapis@e5d5636 Source-Link: googleapis/googleapis-gen@d02b2f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAyYjJmOTIzOWMzZTFkZTY0N2VmMzdmYjEwYTVlNDI0YWEwYjdhNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 5, 2026
…ration (#1251) * feat: New PropertyMask field which allows partial commits, lookups, and query results PiperOrigin-RevId: 635449160 Source-Link: googleapis/googleapis@dde0ec1 Source-Link: googleapis/googleapis-gen@8caa60d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGNhYTYwZDlhZWE4Mjk2NGExOWNkZjhmYWY5MTM4NDkxMWRiOGJkZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: update gapic generator to allow individual location mixin generation PiperOrigin-RevId: 638462084 Source-Link: googleapis/googleapis@e5d5636 Source-Link: googleapis/googleapis-gen@d02b2f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDAyYjJmOTIzOWMzZTFkZTY0N2VmMzdmYjEwYTVlNDI0YWEwYjdhNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1249
Since migrating to v1beta3 we've changed the way we store the
limitvalue, this causes a bug if the user did not set a query limit when retrieving a large number of results.