TextToSpeech: Fix #4595 update default inbound msg size to max#5883
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom Jul 30, 2019
Merged
TextToSpeech: Fix #4595 update default inbound msg size to max#5883chingor13 merged 2 commits intogoogleapis:masterfrom
chingor13 merged 2 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5883 +/- ##
============================================
- Coverage 46.79% 46.41% -0.38%
+ Complexity 25648 24189 -1459
============================================
Files 2456 2456
Lines 267593 262358 -5235
Branches 30564 30414 -150
============================================
- Hits 125225 121779 -3446
+ Misses 133109 132251 -858
+ Partials 9259 8328 -931
Continue to review full report at Codecov.
|
chingor13
requested changes
Jul 26, 2019
Contributor
chingor13
left a comment
There was a problem hiding this comment.
For these synth replacements, we want them to be mostly temporary and fix the issue upstream.
For this one, we should file a feature request to https://github.com/googleapis/gapic-generator to add a gapic config for the maxInboundMessageSize default and add a link to that bug in a comment here.
chingor13
approved these changes
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4595