Add log entry Payload class and tests #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
/cc @lesv |
Contributor
|
I'm happy w/ what is there, but I would expect that something that mentions testing JSON to actually have some raw JSON to either start or compare against. The same could be said of the Struct testing as well. If you disagree, feel free to merge. |
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Jul 20, 2016
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
This PR consists of cherry picks from the https://togithub.com/googleapis/java-datastore/tree/multi-db branch. They include: #928 #940 #942 This also enables parameterized testing for ITDatastoreTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Payloadclass with 3 subclasses, one for each possible payload: UTF8 string, JSON, and protobuf object.JsonPayloadis also exposed as aMap<String, Object>(along with protobuf'sStruct) to be friendlier to users and to be consistent with what we do in other parts of the library.Structsclass contains utility methods to convert fromStructtoMap<String, Object>and back.