Blocks and service days - Clarify relationship of block_id & service_id#44
Conversation
This reverts commit 464b4bd.
|
I think this definition works. Small typo - |
|
It looks as though there is support for this change. Let's start the 7 day voting period for this change, unless anyone has other comments. So that there are 7 full calendar days, then the vote would end on Friday, February 3 @ 23:59:59 UTC. I’m not in love with the formatted example, but I don’t know how better to do this in markdown and in the current document structure. Therefore, I propose that we get block_id definition written into the Spec reference, and leave the door open for reformat/restructure later. |
|
+1 |
|
The voting period has ended. It looks as though there is support for this change. @zhsh: Can you please merge and close? We may want to do a little formatting rearrangement (for the example table) down the line. |
|
@dbabramov Thanks for merging! Friendly request - in the future, could you please squash commits before merging? Github web UI let's you easily do this. I think it's useful to keep a multiple-commit history in a pull request so we can track changes based on comments, but personally I'd prefer to keep the history of the |
It was previously unclear how a block can be defined across service days.
New/added text: "A block consists of a single trip or or many sequential trips made using the same vehicle, defined by shared service day and block_id."
Removed: "The block_id must be referenced by two or more trips in trips.txt."
Note: This proposed change introduces the term of "service day" (see #43 for discussion).