Skip to content

gtfs: Update process to change minimum comment period.#387

Merged
eliasmbd merged 1 commit intogoogle:masterfrom
markstos:swiss-business-days
Sep 4, 2023
Merged

gtfs: Update process to change minimum comment period.#387
eliasmbd merged 1 commit intogoogle:masterfrom
markstos:swiss-business-days

Conversation

@markstos
Copy link
Contributor

First, the spec maintainers are not as Swiss-centric as they used to be
be.

Second, there is only one Swiss national holiday. The rest are
canton-specific, so the spec was not clear anyway.

Ref: https://groups.google.com/g/gtfs-changes/c/cUIt61d95-Y/m/rBTcndx_AgAJ

First, the spec maintainers are not as Swiss-centric as they used to be
be.

Second, there is only one Swiss national holiday. The rest are
canton-specific, so the spec was not clear anyway.

Ref: https://groups.google.com/g/gtfs-changes/c/cUIt61d95-Y/m/rBTcndx_AgAJ
@flocsy
Copy link
Contributor

flocsy commented Jul 20, 2023

+1

1 similar comment
@leonardehrenfried
Copy link
Contributor

+1

@eliasmbd
Copy link
Collaborator

eliasmbd commented Aug 3, 2023

Hey @markstos looks like 3 weeks have passed since you first posted this. Would you like to officially open the vote? This would allow to merge the PR if we are all in agreement. You will need a minimum of 3 (+) votes and no (-) votes. The voting period should last 7 business days according to the current governance. (-) votes need to be justified.

@eliasmbd
Copy link
Collaborator

eliasmbd commented Aug 7, 2023

+1 RideAmigos

Hey Mark, as advocate of the PR you cannot submit a vote. This is specified in the current GTFS amendment process. When assuming the role of advocate you must provide the community with a start and end date for the vote to start. During this period the votes can be counted. At the end of the period the PR can be merged.

This amendment process will be discussed in our upcoming workshops in Valencia on September 5-6 as well as the workshops in New York on October 16-17. I recommend would anyone that wants to help us propose a better amendment process to join us there. We hope to identify multiple pain points and propose viable solutions with community members.

@markstos
Copy link
Contributor Author

markstos commented Aug 7, 2023

@eliasmbd Thanks for the feedback. The spec doesn't say the proposing person cannot submit a vote, it says "The proposer's vote does not count". So, it was a valid but pointless vote.

I'll announce the end date. I would love to join you in Valencia-- I'm currently learning Spanish-- but the travel time and expense from Indiana is not feasible for us this year.

@markstos
Copy link
Contributor Author

markstos commented Aug 7, 2023

One thing that could help is template to use for the announcement message. That could help insure all required details are present.

@eliasmbd
Copy link
Collaborator

eliasmbd commented Aug 7, 2023

The spec doesn't say the proposing person cannot submit a vote, it says "The proposer's vote does not count". So, it was a valid but pointless vote.

True ;) I stand corrected. Maybe i'll start voting on these PRs too :P

One thing that could help is template to use for the announcement message. That could help insure all required details are present.

📝 Taking note of this! I know we were working on this internally but I really want to get more people to contribute with PRs so, templates and visual tools would really help.

@skinkie
Copy link
Contributor

skinkie commented Aug 8, 2023

+1 OpenGeo

@leonardehrenfried
Copy link
Contributor

+1 OpenTripPlanner

@emmambd emmambd added the Vote to Test Community votes to determine whether the proposal is ready for testing. label Aug 8, 2023
@philip-cline
Copy link

+1 Arcadis IBI Group

@lauramatson
Copy link

+1 Metro Transit (Minneapolis/St. Paul, Minnesota)

@markstos
Copy link
Contributor Author

markstos commented Sep 1, 2023

Voting for this is now closed. Thanks to those who participated.

@emmambd emmambd removed the Vote to Test Community votes to determine whether the proposal is ready for testing. label Sep 3, 2023
@eliasmbd
Copy link
Collaborator

eliasmbd commented Sep 4, 2023

@markstos Thank you for your advocacy on this PR! The vote has passed and will be merged.

@eliasmbd eliasmbd merged commit 17c5eef into google:master Sep 4, 2023
@markstos markstos deleted the swiss-business-days branch September 5, 2023 16:11
gcamp pushed a commit to TransitApp/transit that referenced this pull request Sep 25, 2023
First, the spec maintainers are not as Swiss-centric as they used to be
be.

Second, there is only one Swiss national holiday. The rest are
canton-specific, so the spec was not clear anyway.

Ref: https://groups.google.com/g/gtfs-changes/c/cUIt61d95-Y/m/rBTcndx_AgAJ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants