This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Allowed for retrieving GPU objects.#424
Open
chihuahua wants to merge 1 commit intogoogle:masterfrom
chihuahua:categorizeObjects
Open
Allowed for retrieving GPU objects.#424chihuahua wants to merge 1 commit intogoogle:masterfrom chihuahua:categorizeObjects
chihuahua wants to merge 1 commit intogoogle:masterfrom
chihuahua:categorizeObjects
Conversation
ghost
assigned
src/wtf/replay/graphics/playback.js
Outdated
Contributor
There was a problem hiding this comment.
Is this required? I thought the compiler would pick up on this - lame if it doesn't :(
Contributor
Author
There was a problem hiding this comment.
The compiler seems to view objectType as a string ... does this casting actually incur overhead?
Contributor
There was a problem hiding this comment.
Lame - they should be able to know the key type - oh well. No runtime overhead, just cognitive overhead while reading.
Contributor
Author
There was a problem hiding this comment.
Hmm, looks like lint notes that I have to use parseInt instead of just casting...
Refactored Playback to allow for retrieving GPU objects of desired type. This makes it feasible to, for instance, list the textures up to a certain step. The object mapping was changed from (handle to object) to (type of object to object handle to object).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored Playback to allow for retrieving GPU objects of a desired type. This makes it feasible to, for instance, list the textures up to a certain step. The object mapping was changed from (handle to object) to (type of object to object handle to object).