chore: fix usage of timeout in alpine E2E test#92
Merged
nolanmar511 merged 2 commits intogoogle:masterfrom Nov 20, 2019
Merged
Conversation
Contributor
Author
jqll
approved these changes
Nov 20, 2019
| function timeout_after() { | ||
| if [ -f /bin/busybox ]; then | ||
| # timeout on Node 11 alpine image requires -t to specify time. | ||
| if [ -f /bin/busybox ] && [[ $(node -v) =~ ^v11.* ]]; then |
Contributor
There was a problem hiding this comment.
Nit: let's use either double brackets or single for both? But I'm approving the change to stop the alerts.
Contributor
Author
There was a problem hiding this comment.
I think the double and single brackets have slightly different semantics (I need double brackets for the second condition; I'm not sure if I can use them for the first).
I'll look into addressing this in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.