fix: retry npm install in system test when command hangs#65
Merged
nolanmar511 merged 2 commits intogoogle:masterfrom May 22, 2019
Merged
fix: retry npm install in system test when command hangs#65nolanmar511 merged 2 commits intogoogle:masterfrom
nolanmar511 merged 2 commits intogoogle:masterfrom
Conversation
aalexand
approved these changes
May 22, 2019
Contributor
aalexand
left a comment
aalexand
left a comment
There was a problem hiding this comment.
Isn't it more of a "fix" than a "chore"?
nolanmar511
changed the title
aalexand
reviewed
May 22, 2019
nolanmar511
force-pushed
the
retry-npm-install
branch
2 times, most recently
from
873f31a to
70d4fc5
Compare
aalexand
reviewed
May 22, 2019
system-test/test.sh
Outdated
| "${@}" || "${@}" || "${@}" || return 1 | ||
| } | ||
|
|
||
| function wait_only() { |
Contributor
There was a problem hiding this comment.
Subjective: I'd call it timeout_after.
Contributor
Author
There was a problem hiding this comment.
That's definitely better!
Done.
aalexand
approved these changes
May 22, 2019
kalyanac
reviewed
May 22, 2019
nolanmar511
force-pushed
the
retry-npm-install
branch
from
70d4fc5 to
0ed0e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.