chore(deps)!: update typescript to v5 and gts to v5#285
Merged
aabmass merged 1 commit intogoogle:mainfrom Feb 2, 2024
Merged
Conversation
aabmass
force-pushed
the
upgrade-ts-gts
branch
from
a889b8a to
3203a97
Compare
aabmass
commented
Feb 2, 2024
psx95
approved these changes
Feb 2, 2024
Contributor
psx95
left a comment
psx95
left a comment
There was a problem hiding this comment.
A little unclear on the details on the breaking changes you mention. But changes look ok.
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially breaking change as typescript compilation output is not guaranteed to be compatible across major versions.
This combines #285 and #266 together. I fixed a few type errors from the upgrade. Specific versions copied from package.json in cloud-profiler-nodejs downstream