chore: fix publish.sh to work with kokoro#279
Merged
aabmass merged 1 commit intogoogle:mainfrom Jan 31, 2024
Merged
Conversation
aabmass
commented
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 14 14
Lines 2093 2093
Branches 42 42
=======================================
Hits 878 878
Misses 1197 1197
Partials 18 18 ☔ View full report in Codecov by Sentry. |
psx95
reviewed
Jan 31, 2024
psx95
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update nvm and the NodeJS version it pulls in.
See the bug for more details. The upgraded NodeJS uses a newer NPM that doesn't complain about when being run as root.
I tested it out by in a local kokoro container and
--dry-runflag–the tarball builds correctly: