test: temporarily workaround node 18 source-map issue#211
Closed
amchiclet wants to merge 1 commit intogoogle:mainfrom
Closed
test: temporarily workaround node 18 source-map issue#211amchiclet wants to merge 1 commit intogoogle:mainfrom
amchiclet wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
Author
|
Subsumed by #213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a beta version of
source-mapwhich works around its incompatibility with node 18. The most recent official version doesn't work with node 18 yet.An alternative solution is to workaround it when importing source-map, like this PR.
I've chosen the simpler path for now to just use the beta version and will revisit this issue probably a couple of weeks later to see if there's any update from source-map or not.
Our kokoro tests run into a different issue that I'll address in a separate PR, but the github workflow tests should pass now.