test: use latest stable instead of canary in system test#193
Merged
nolanmar511 merged 1 commit intogoogle:mainfrom Dec 20, 2021
amchiclet:main
Merged
test: use latest stable instead of canary in system test#193nolanmar511 merged 1 commit intogoogle:mainfrom amchiclet:main
nolanmar511 merged 1 commit intogoogle:mainfrom
amchiclet:main
Conversation
nolanmar511
reviewed
Dec 20, 2021
nolanmar511
approved these changes
Dec 20, 2021
aabmass
pushed a commit
to aabmass/pprof-nodejs
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched from Canary to latest.
For non-alpine, this means using
nvm install nodeto get the latest stable version of node.For alpine, this means using the docker image
node:current-alpine.Also removed the
NVM_NODEJS_ORG_MIRRORenvironment variable.