Skip to content

feat: add pre-built binaries and support for Node 16 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolanmar511 merged 2 commits into from
May 26, 2021
Merged

feat: add pre-built binaries and support for Node 16 #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f7648
feat: add pre-built binaries and support for Node 16
nolanmar511 May 26, 2021
e2f172a
Merge branch 'main' into support-16
nolanmar511 May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 10, 12, 14, 15]
node: [ 10, 12, 14, 15, 16]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
Expand Down
14 changes: 14 additions & 0 deletions system-test/Dockerfile.node16-alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
FROM golang:1.16-alpine as builder
RUN apk add --no-cache git
WORKDIR /root/
RUN go get github.com/google/pprof


FROM node:16-alpine

ARG ADDITIONAL_PACKAGES

RUN apk add --no-cache bash $ADDITIONAL_PACKAGES
WORKDIR /root/
COPY --from=builder /go/bin/pprof /bin
RUN chmod a+x /bin/pprof
4 changes: 2 additions & 2 deletions system-test/system_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ set -eox pipefail
cd $(dirname $0)

if [[ -z "$BINARY_HOST" ]]; then
ADDITIONAL_PACKAGES="python g++ make"
ADDITIONAL_PACKAGES="python3 g++ make"
fi

if [[ "$RUN_ONLY_V8_CANARY_TEST" == "true" ]]; then
NVM_NODEJS_ORG_MIRROR="https://nodejs.org/download/v8-canary"
NODE_VERSIONS=(node)
else
NODE_VERSIONS=(10 12 14 15)
NODE_VERSIONS=(10 12 14 15 16)
fi

for i in ${NODE_VERSIONS[@]}; do
Expand Down
2 changes: 1 addition & 1 deletion tools/build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mkdir -p "$ARTIFACTS_OUT"

npm install --quiet

for version in 10.0.0 12.0.0 14.0.0 15.0.0
for version in 10.0.0 12.0.0 14.0.0 15.0.0 16.0.0
do
./node_modules/.bin/node-pre-gyp configure rebuild package \
--target=$version --target_arch="x64"
Expand Down