Skip to content

chore: add backoff to retry function used in e2e test#120

Merged
aalexand merged 2 commits intogoogle:masterfrom
nolanmar511:retry-backoff
May 20, 2020
Merged

chore: add backoff to retry function used in e2e test#120
aalexand merged 2 commits intogoogle:masterfrom
nolanmar511:retry-backoff

Conversation

@nolanmar511
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to have the function defined once in a common file and source it from other files.

@aalexand aalexand merged commit 1840de0 into google:master May 20, 2020
@nolanmar511
Copy link
Copy Markdown
Contributor Author

I moved retry into its own bash script, and import it throughout.

PTAL.

@nolanmar511 nolanmar511 requested a review from kalyanac May 20, 2020 14:42
@aalexand
Copy link
Copy Markdown
Contributor

aalexand commented May 20, 2020 via email

@nolanmar511
Copy link
Copy Markdown
Contributor Author

Thanks! -- all desired changes were in yesterday. Must've missed that this was merged this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants