chore: start running unit tests with GitHub workflows#106
Merged
nolanmar511 merged 2 commits intogoogle:masterfrom Mar 25, 2020
Merged
chore: start running unit tests with GitHub workflows#106nolanmar511 merged 2 commits intogoogle:masterfrom
nolanmar511 merged 2 commits intogoogle:masterfrom
Conversation
nolanmar511
changed the title
nolanmar511
force-pushed
the
github-workflows
branch
4 times, most recently
from
4fde40b to
bdefe17
Compare
nolanmar511
force-pushed
the
github-workflows
branch
from
bdefe17 to
d8c4573
Compare
nolanmar511
changed the title
kalyanac
reviewed
Mar 24, 2020
kalyanac
reviewed
Mar 24, 2020
kalyanac
reviewed
Mar 24, 2020
kalyanac
approved these changes
Mar 25, 2020
nolanmar511
force-pushed
the
github-workflows
branch
from
897ae8b to
e60fec8
Compare
nolanmar511
force-pushed
the
github-workflows
branch
from
e60fec8 to
ad23bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested: Pushed this commit to my master branch; all tests pass.
https://github.com/nolanmar511/pprof-nodejs/actions/runs/62508944
The ci.yaml used here is the same as the ci.yaml used in cloud-profiler-nodejs, but with the "docs" check removed.
I believe the added GitHub workflow will start running as presubmit checks once this PR is submitted.
Tests with the following names will appear as presubmit checks (basing this on github workflow tests which appear for cloud-profiler-nodejs):