Update multichase implementation#51
Merged
seranian merged 1 commit intogoogle:masterfrom Apr 10, 2026
Merged
Conversation
seranian
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update multichase implementation.
The current multichase implementation rounds total memory down to the nearest multiple of TLB locality (tlb_locality), causing significant buffer shrinkage (e.g., 4000KB to 1952KB with -T 2m). This distortion leads to a false perception of cache limits and inaccurate boundary size detection.
This change removes the unnecessary rounding in multichase.c and updates the chase generation logic in permutation.c to properly handle partial TLB groups at the end of the memory. This ensures that the entire requested memory size (rounded to stride) is used for the chase without incurring excessive TLB misses.