Skip to content

python: do not alter warnings' filter #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyammer merged 3 commits into from
Mar 27, 2025
Merged

python: do not alter warnings' filter #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eb995e
python: do not alter warnings' filter
reyammer Mar 27, 2025
479361d
python: update changelog
reyammer Mar 27, 2025
ea40062
python: don't ignore warnings in pytest
reyammer Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ semver guidelines for more details about this.

- Mark python 3.13 as supported.
- Bugfix: limit the number of bytes we read in case of an input with just many whitespaces. ([#1015](https://github.com/google/magika/pull/1015))
- Bugfix: do not alter warnings' simplefilter as this has visible side effects for other modules. ([#1017](https://github.com/google/magika/pull/1017))


## [0.6.1] - 2025-03-19
Expand Down
2 changes: 0 additions & 2 deletions python/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
[pytest]
log_cli = 1
log_level = WARNING
filterwarnings =
ignore::DeprecationWarning

markers =
smoketest
Expand Down
4 changes: 2 additions & 2 deletions python/src/magika/types/content_type_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
from magika.logger import get_logger
from magika.types.content_type_label import ContentTypeLabel

warnings.simplefilter("always", DeprecationWarning)


@dataclass(frozen=True)
class ContentTypeInfo:
Expand All @@ -22,6 +20,7 @@ def ct_label(self) -> str:
warnings.warn(
"`.ct_label` is deprecated and will be removed in a future version. Use `.label` instead. Consult the documentation for more information.",
category=DeprecationWarning,
stacklevel=2,
)
return str(self.label)

Expand All @@ -37,5 +36,6 @@ def magic(self) -> str:
warnings.warn(
"`.magic` is deprecated and will be removed in a future version. Use `.description` instead. Consult the documentation for more information.",
category=DeprecationWarning,
stacklevel=2,
)
return self.description
Loading