Skip to content

Conversation

@alexandear
Copy link
Contributor

This PR standardizes parameter naming from opt to opts in multiple service methods. Renaming function parameters does not break compatibility, so this change is safe.

opts is more commonly used throughout the repository:

grep -r 'opt \*' --include='*.go' --exclude-dir=testdata . | wc -l
       7grep -r 'opts \*' --include='*.go' --exclude-dir=testdata . | wc -l
     321

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (e1238d0) to head (784db54).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3887   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files         200      200           
  Lines       14564    14564           
=======================================
  Hits        13469    13469           
  Misses        895      895           
  Partials      200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title fix: Rename 'opt' to 'opts' in multiple methods chore: Rename 'opt' to 'opts' in multiple methods Dec 17, 2025
@gmlewis gmlewis merged commit ecab7f1 into google:master Dec 17, 2025
7 checks passed
@alexandear alexandear deleted the refactor/rename-opt-to-opts branch December 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants