Set the secondary EOS for Gemma2 #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-wassenberg
approved these changes
Mar 21, 2025
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
LGTM, @pculliton, any thoughts?
pculliton
approved these changes
Mar 21, 2025
Collaborator
pculliton
left a comment
pculliton
left a comment
There was a problem hiding this comment.
Great changes - thank you for making them!
jan-wassenberg
added
the
copybara-import
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
We have a merge conflict, can you please rebase?
jan-wassenberg
removed
the
copybara-import
The secondary eos is usually `<end_of_turn>`, which can appear in the prompt, so we can only check it not in the prompt.
So that we can remove the `<end_of_turn>` filter that was set up specifically for Gemma2.
ufownl
force-pushed
the
feature/gemma2_secondary_eos
branch
from
cbb84e1 to
d42deaa
Compare
Contributor
Author
|
I have rebased, but no conflict complained by git. |
jan-wassenberg
approved these changes
Mar 21, 2025
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Thanks! It could be that our copybara import was stuck, hopefully this will unblock it.
jan-wassenberg
added
the
copybara-import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the
<end_of_turn>filter that was set up specifically for Gemma2 and fixes the EOS checking.