Conversation
…GCP IAP) Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
manugarg
left a comment
There was a problem hiding this comment.
Thanks for this PR, @ali-sattari. Please take a look at my comment.
manugarg
left a comment
There was a problem hiding this comment.
Looks good now. Thanks.
I'll start the merge process as per:
https://github.com/google/cloudprober/blob/master/CONTRIBUTING.md#source-of-truth-sot-and-commit-process
Fallback to extra fields provided if AccessToken is empty (case witt GCP IAP)
Fixes #480