Skip to content
This repository was archived by the owner on Nov 5, 2021. It is now read-only.

Fallback for empty AccessToken#481

Closed
ali-sattari wants to merge 2 commits intogoogle:masterfrom
ali-sattari:oauth-iap-fix
Closed

Fallback for empty AccessToken#481
ali-sattari wants to merge 2 commits intogoogle:masterfrom
ali-sattari:oauth-iap-fix

Conversation

@ali-sattari
Copy link
Contributor

Fallback to extra fields provided if AccessToken is empty (case witt GCP IAP)

Fixes #480

…GCP IAP)

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
@google-cla
Copy link

google-cla bot commented Oct 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ali-sattari
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @ali-sattari. Please take a look at my comment.

@ali-sattari ali-sattari requested a review from manugarg October 4, 2020 07:40
Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manugarg
Copy link
Contributor

manugarg commented Oct 5, 2020

Commited through #483: f40ed7e.

Thank you once again!

@manugarg manugarg closed this Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth2 with Google Credentials and ServiceAccount key doesn't support id_token

2 participants