new: more strict naming for service definitions#208
Merged
copybara-service[bot] merged 2 commits intogoogle:masterfrom Aug 25, 2020
Merged
Conversation
cryptaliagy
force-pushed
the
feature/strict_definition_naming
branch
from
7be16eb to
2741bcb
Compare
rdsharma
approved these changes
Jul 24, 2020
Contributor
|
Did we decide to abandon this one? |
Contributor
Author
|
We had a small conversation on whether it should still be around. I think it would be advisable to keep it but remove the strict requirement, since if we allow it as a first-pass we will still add some efficiency |
rdsharma
reviewed
Aug 6, 2020
cryptaliagy
force-pushed
the
feature/strict_definition_naming
branch
from
2741bcb to
25dbe42
Compare
rdsharma
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more strict rules to service definition naming, and used these rules to infer if a token is an IP or a service during GetNet