Skip to content

Fixes new clippy lints on the latest nightly#603

Merged
kaczmarczyck merged 2 commits intogoogle:developfrom
kaczmarczyck:clippy-lints
Mar 9, 2023
Merged

Fixes new clippy lints on the latest nightly#603
kaczmarczyck merged 2 commits intogoogle:developfrom
kaczmarczyck:clippy-lints

Conversation

@kaczmarczyck
Copy link
Copy Markdown
Collaborator

Now that we can use a later toolchain, we see more lints. Overlaps with #580 , but I didn't reproduce all lints. Missing are all changes like:

-                large_blob_data.extend(&[0x0C, 0x00]);
+                large_blob_data.extend([0x0C, 0x00]);

Not sure what toolchain version these are coming from.

On a side note, other libraries still have lints that need to be fixed on the current nightly.

We didn't see these before because of our old Rust toolchain.
@kaczmarczyck kaczmarczyck requested a review from ia0 March 9, 2023 10:25
@kaczmarczyck kaczmarczyck self-assigned this Mar 9, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 9, 2023

Coverage Status

Coverage: 96.176% (+0.1%) from 96.058% when pulling b5b8cce on kaczmarczyck:clippy-lints into ca65902 on google:develop.

ia0
ia0 previously approved these changes Mar 9, 2023
Comment thread libraries/opensk/src/ctap/client_pin.rs Outdated
@kaczmarczyck kaczmarczyck merged commit 752db8c into google:develop Mar 9, 2023
@kaczmarczyck kaczmarczyck deleted the clippy-lints branch March 9, 2023 11:08
@kaczmarczyck kaczmarczyck mentioned this pull request Mar 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants