Fixes new clippy lints on the latest nightly#603
Merged
kaczmarczyck merged 2 commits intogoogle:developfrom Mar 9, 2023
Merged
Fixes new clippy lints on the latest nightly#603kaczmarczyck merged 2 commits intogoogle:developfrom
kaczmarczyck merged 2 commits intogoogle:developfrom
Conversation
We didn't see these before because of our old Rust toolchain.
ia0
previously approved these changes
Mar 9, 2023
ia0
approved these changes
Mar 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we can use a later toolchain, we see more lints. Overlaps with #580 , but I didn't reproduce all lints. Missing are all changes like:
Not sure what toolchain version these are coming from.
On a side note, other libraries still have lints that need to be fixed on the current nightly.