Enqueue form styles for hosted payment forms#610
Merged
unfulvio-godaddy merged 6 commits intorelease/5.11.7from Jul 27, 2023
Merged
Enqueue form styles for hosted payment forms#610unfulvio-godaddy merged 6 commits intorelease/5.11.7from
unfulvio-godaddy merged 6 commits intorelease/5.11.7from
Conversation
unfulvio-godaddy
approved these changes
Jul 27, 2023
Contributor
unfulvio-godaddy
left a comment
unfulvio-godaddy
left a comment
There was a problem hiding this comment.
LGTM - I have added a changelog entry, and a since tag to the newly added method
unfulvio-godaddy
deleted the
fix/enqueue-form-styles-for-hosted-payment-forms
branch
unfulvio-godaddy
pushed a commit
that referenced
this pull request
Jul 28, 2023
* 5.11.7 dev versioning and changelog entry * version 5.11.7 * Enqueue form styles for hosted payment forms (#610) * load payment form assets for gateways that support adding payment methods also * use flexbox for aligning payment gateway icons * extract selector styles to method * Ensure FW gateways with no CC icons still align to the right * Add since version to newly added method * Update changelog --------- Co-authored-by: Fulvio Notarstefano <fulvio.notarstefano@gmail.com> * update changelog * Version 5.11.7 --------- Co-authored-by: nikolas4175-godaddy <nikolas4175@godaddy.com> Co-authored-by: Fulvio Notarstefano <fulvio.notarstefano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does 2 things:
The latter change is bigger of the 2, and affects all FW-d plugins. I tested with 3 different gateways on different scenarios. I'm attaching the screenshots of the results. Ideally, we would contribute to WC core an update to use flexbox for the selector styling, as this makes achieving the proper alignment much easier.