-
Notifications
You must be signed in to change notification settings - Fork 12
gh-903: Port galaxies.py to support jax #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5b007e3 to
ac85e56
Compare
|
paddyroddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. How do we know it's a genuine reduction this time?
I'm assuming it is, as the only tests which seem to regularly show up as regressed is |
|
That would make sense. Thankfully not a huge regression. Performance has regressed:
test_galaxy_shear[numpy-True] (0001_f906eb0) - Field 'mean' has failed PercentageRegressionCheck: 9.996939723 > 5.000000000
test_galaxy_shear[numpy-False] (0001_f906eb0) - Field 'mean' has failed PercentageRegressionCheck: 8.899524405 > 5.000000000 |
Description
Ports functions in galaxies.py which mutate arrays to now use
xpx.at...so they support jax.Closes: #903
Changelog entry
Added: jax support for
glass.galaxies.redshifts_from_nzandglass.galaxies.galaxy_shear.Checks