-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update pr template #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoannaaKL
wants to merge
2
commits into
main
Choose a base branch
from
add-pr-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update pr template #1605
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,38 @@ | ||
| <!-- | ||
| Thank you for contributing to GitHub MCP Server! | ||
| Please reference an existing issue: `Closes #NUMBER` | ||
| Screenshots or videos of changed behavior is incredibly helpful and always appreciated. | ||
| Consider addressing the following: | ||
| - Tradeoffs: List tradeoffs you made to take on or pay down tech debt. | ||
| - Alternatives: Describe alternative approaches you considered and why you discarded them. | ||
| Copilot: Fill all sections. Prefer short, concrete answers. | ||
| If a checkbox is selected, add a brief explanation. | ||
| --> | ||
|
|
||
| Closes: | ||
| ## Summary | ||
| <!-- In 1–2 sentences: what does this PR do? --> | ||
|
|
||
| ## Why | ||
| <!-- Why is this change needed? Link issues or discussions. --> | ||
| Fixes # | ||
|
|
||
| ## What changed | ||
| <!-- Bullet list of concrete changes. --> | ||
| - | ||
| - | ||
|
|
||
| ## MCP impact | ||
| <!-- Select one or more. If selected, add 1–2 sentences. --> | ||
| - [ ] No tool or API changes | ||
| - [ ] Tool schema or behavior changed | ||
| - [ ] New tool added | ||
|
|
||
| ## Security / limits | ||
| <!-- Select if relevant. Add a short note if checked. --> | ||
| - [ ] No security or limits impact | ||
| - [ ] Auth / permissions considered | ||
| - [ ] Data exposure, filtering, or token/size limits considered | ||
|
|
||
| ## Lint & tests | ||
| <!-- Check what you ran. If not run, explain briefly. --> | ||
| - [ ] Linted locally with `./script/lint` | ||
| - [ ] Tested locally with `./script/test` | ||
|
|
||
| ## Docs | ||
|
|
||
| - [ ] Not needed | ||
| - [ ] Updated (README / docs / examples) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a section asking to add prompts tested for triggering the tool (tool changes only)
I think we really want to understand what they want to achieve, not just their solution so that if we disagree with the solution we can still consider the problem they are hoping to solve and consider how we would solve it.
Collecting use-case would be high value for product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, point! @copilot add a section asking to add prompts tested for triggering the tool (only for tool changes).