fix: remove crates.io domains from python ecosystem entry#26430
Merged
fix: remove crates.io domains from python ecosystem entry#26430
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d6b0d5a0-7f5d-4f20-a42e-39c821f8db69 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove crates.io domains from python entry
fix: remove crates.io domains from python ecosystem entry
Apr 15, 2026
pelikhan
approved these changes
Apr 15, 2026
Collaborator
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Rust registry domains from the python ecosystem domain allowlist to restore least-privilege network isolation for workflows that use network.allow: [python].
Changes:
- Removed
crates.io,index.crates.io, andstatic.crates.iofrom thepythondomain list. - Kept those domains correctly listed under the
rustecosystem.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/data/ecosystem_domains.json | Removes Rust registry domains from the Python ecosystem allowlist while retaining them under Rust. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced Apr 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/workflow/data/ecosystem_domains.jsonincorrectly included three Rust registry domains (crates.io,index.crates.io,static.crates.io) under thepythonecosystem — a copy-paste error. Any workflow usingnetwork.allow: [python]silently received Rust registry access, violating least-privilege network isolation.Changes
pkg/workflow/data/ecosystem_domains.json: Remove the threecrates.ioentries from thepythonarray; they remain correctly listed underrust.