fix(smoke-gemini): trigger on "smoke" label instead of "water"#25639
fix(smoke-gemini): trigger on "smoke" label instead of "water"#25639
Conversation
…23655) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/c13cbf90-eb49-413d-804f-a3bdc0ee0fb8 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey A couple of small things to consider before moving out of draft:
If you'd like a hand tidying this up, you can assign this prompt to your coding agent:
|
There was a problem hiding this comment.
Pull request overview
Updates the smoke-gemini workflow to run as part of the standard smoke test suite by triggering on the smoke label (instead of water, which is reserved for cross-repo/service-port tests).
Changes:
- Switch
smoke-geminilabel trigger fromwatertosmokein the source workflow definition. - Recompile the locked workflow so its runtime
if:conditions now check forgithub.event.label.name == 'smoke'.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/smoke-gemini.md |
Changes label filter to smoke for PR labeled triggers. |
.github/workflows/smoke-gemini.lock.yml |
Updates generated workflow conditions to match the new smoke label trigger. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
smoke-geminiwas configured to trigger on thewaterlabel, which is reserved for cross-repo/service-port tests. This misalignment excluded it from the standard smoke test suite that runs when PRs are labeledsmoke.Changes
.github/workflows/smoke-gemini.md:names: ["water"]→names: ["smoke"], consistent withsmoke-claude,smoke-codex, andsmoke-test-tools.github/workflows/smoke-gemini.lock.yml: Recompiled — condition now checksgithub.event.label.name == 'smoke'Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw(http block)https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b/usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha(http block)https://api.github.com/repos/github/gh-aw/usr/bin/gh gh api /repos/github/gh-aw --jq .visibility(http block)https://api.github.com/repos/githubnext/agentics/git/ref/tags/-/usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/- --jq .object.sha(http block)If you need me to access, download, or install something from one of these locations, you can either: