Skip to content

fix(smoke-gemini): trigger on "smoke" label instead of "water"#25639

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-trigger-smoke-label
Apr 10, 2026
Merged

fix(smoke-gemini): trigger on "smoke" label instead of "water"#25639
pelikhan merged 2 commits intomainfrom
copilot/fix-trigger-smoke-label

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026

smoke-gemini was configured to trigger on the water label, which is reserved for cross-repo/service-port tests. This misalignment excluded it from the standard smoke test suite that runs when PRs are labeled smoke.

Changes

  • .github/workflows/smoke-gemini.md: names: ["water"]names: ["smoke"], consistent with smoke-claude, smoke-codex, and smoke-test-tools
  • .github/workflows/smoke-gemini.lock.yml: Recompiled — condition now checks github.event.label.name == 'smoke'

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/-
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/- --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix smoke-gemini workflow trigger on "smoke" label fix(smoke-gemini): trigger on "smoke" label instead of "water" Apr 10, 2026
Copilot AI requested a review from pelikhan April 10, 2026 12:50
@github-actions
Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — great catch on the smoke-gemini label misalignment! Fixing the trigger from watersmoke brings it into line with smoke-claude, smoke-codex, and smoke-test-tools, which is exactly the consistency the smoke suite needs.

A couple of small things to consider before moving out of draft:

  • Tests — The diff doesn't include changes to any test files. For a workflow config fix like this, traditional unit tests don't apply directly, but it's worth verifying that the compiled .lock.yml was regenerated with make agent-finish (or equivalent recompile step) so the frontmatter hash in the metadata comment is consistent with the source .md. If there's a snapshot or integration test that validates lock file integrity against the source, that would be worth running and capturing too.
  • Draft status — The PR is still marked as draft. Once you've confirmed the recompile is clean and the smoke label trigger fires correctly in a test run, it's ready to be marked ready for review.

If you'd like a hand tidying this up, you can assign this prompt to your coding agent:

In the gh-aw repository, verify that PR #25639 is fully consistent:
1. Confirm that `.github/workflows/smoke-gemini.lock.yml` was correctly recompiled from `.github/workflows/smoke-gemini.md` after changing `names: ["water"]` to `names: ["smoke"]`.
2. Run `make agent-finish` (or the equivalent lock-file recompile command) and check that the output matches the current state of the lock file in the PR branch.
3. If there are any snapshot or CI tests for workflow lock-file integrity, run them and ensure they pass.
4. If everything looks good, mark the PR as ready for review.

Generated by Contribution Check · ● 3.2M ·

@pelikhan pelikhan marked this pull request as ready for review April 10, 2026 14:34
Copilot AI review requested due to automatic review settings April 10, 2026 14:34
@pelikhan pelikhan merged commit 7b2108a into main Apr 10, 2026
54 checks passed
@pelikhan pelikhan deleted the copilot/fix-trigger-smoke-label branch April 10, 2026 14:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the smoke-gemini workflow to run as part of the standard smoke test suite by triggering on the smoke label (instead of water, which is reserved for cross-repo/service-port tests).

Changes:

  • Switch smoke-gemini label trigger from water to smoke in the source workflow definition.
  • Recompile the locked workflow so its runtime if: conditions now check for github.event.label.name == 'smoke'.
Show a summary per file
File Description
.github/workflows/smoke-gemini.md Changes label filter to smoke for PR labeled triggers.
.github/workflows/smoke-gemini.lock.yml Updates generated workflow conditions to match the new smoke label trigger.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[q] fix(smoke-gemini): trigger on "smoke" label instead of "water" (#23655)

3 participants