Skip to content

Add DefaultEngine constant and replace semantic-default uses of CopilotEngine#24554

Merged
dsyme merged 5 commits intomainfrom
copilot/define-default-engine-constant
Apr 4, 2026
Merged

Add DefaultEngine constant and replace semantic-default uses of CopilotEngine#24554
dsyme merged 5 commits intomainfrom
copilot/define-default-engine-constant

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026

CopilotEngine was being used in two distinct roles: as the copilot engine identifier and as a stand-in for "the default engine." This conflates identity with defaultness, making it harder to change the default engine in the future.

Changes

  • New constantconstants.DefaultEngine EngineName = CopilotEngine added to engine_constants.go
  • add_command.go — Skip-if-default check now uses DefaultEngine (comment already noted "Copilot is the default engine")
  • add_interactive_engine.go — Initial defaultEngine assignment and two fallback-check conditions updated to DefaultEngine
  • agentic_engine.goGetDefaultEngine() replaced hardcoded "copilot" string with string(constants.DefaultEngine)
  • constants_test.go — Added assertion that DefaultEngine == CopilotEngine

Copilot-specific usages (e.g., engine_secrets.go, domains.go) are intentionally left as CopilotEngine — they refer to Copilot's concrete behavior, not the default selection.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -o cfg git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url /usr/bin/git 5824-31321/test-git pkg/mod/github.crev-parse ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name 35981682/001' 35981682/001' x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json 1.4.1/internal/x-ifaceassert x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --show-toplevel x_amd64/vet /usr/bin/git _.a hOYFQ3cxW 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git itmain_branch183git itmain_branch183rev-parse 64/pkg/tool/linu--show-toplevel /usr/bin/git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha ErrorFormatting3057707204/001 --format=%(objectname) 046786/b434/_pkg_.a -c=4 -nolocalimports -importcfg infocmp -1 s/test.md /home/REDACTED/work/gh-aw/gh-aw/pkg/constants/engine_constants.go /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json ase64.go x_amd64/compile node (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha 55/001/test-simple-frontmatter.md 046786/b020/vet.cfg 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha xterm-color 64/pkg/tool/linux_amd64/vet /usr/bin/git rtcfg cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git 4222200763 GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git 046786/b420/_pkggit /tmp/go-build616rev-parse 046786/b420=> git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git licyMinIntegritygit /tmp/go-build616rev-parse cfg git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha master IwtLslUObn8g /opt/hostedtoolcache/node/24.14.1/x64/bin/node _.a GO111MODULE x_amd64/vet node /tmp�� /home/REDACTED/work/gh-aw/gh-aw/.github/workflows/agent-persona-explorer.md x_amd64/vet /usr/bin/git _.a i0dFibft1 x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha GOMODCACHE uCBMY_q/kxuNWYohconfig /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json GO111MODULE x_amd64/vet node /tmp�� /home/REDACTED/work/gh-aw/gh-aw/.github/workflows/agentic-observability-kit.md x_amd64/vet /usr/bin/git _.a GO111MODULE x_amd64/vet git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq .object.sha -aw-actions/git/ref/tags/v1.2.3 ache/go/1.25.8/x-extld=gcc /usr/bin/git agent-persona-exgit -trimpath /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git faultBranchFromLgit faultBranchFromLrev-parse trepo.git git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env adata/main.go GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha user.email test@example.com /usr/bin/git 346 GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git _.a GO111MODULE x_amd64/vet git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha GOMODCACHE x_amd64/vet /usr/bin/git _.a GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git _.a lNGu_38wk x_amd64/compile git (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha 999 -buildtags /usr/lib/git-core/git-receive-pack -errorsas -ifaceassert -nilfunc git-receive-pack /tmp�� -stringintconv l 1/x64/bin/node -json GO111MODULE x_amd64/compile 1/x64/bin/node (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq .object.sha -b test-branch /usr/bin/git _.a GOPROXY x_amd64/vet git rev-�� --git-dir x_amd64/vet /usr/bin/git _.a sYYP-7R33 x_amd64/vet git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq .object.sha k/gh-aw/gh-aw -buildtags /usr/lib/git-core/git-upload-pack -errorsas -ifaceassert -nilfunc git-upload-pack /tmp�� -stringintconv l e/git -json GO111MODULE x_amd64/compile e/git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq .object.sha ithub/workflows/agent-persona-explorer.md -buildtags /usr/bin/git -errorsas -ifaceassert -nilfunc git clon�� /tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branch3539958920/001 /tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branch3539958920/002/work om/testowner/testrepo.git -json GO111MODULE x_amd64/compile git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b011/ GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b180/_pkg_.a cfg til.test GOINSECURE 955208/b011/preerev-parse ache/go/1.25.8/x--show-toplevel til.test (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 3660151874 O8a-/w8uJjXynBhCHi02xO8a- cfg GOINSECURE hpke GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b121/_pkg_.a cfg 64/pkg/tool/linux_amd64/vet GOINSECURE /go-yaml GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 LsRemoteWithRealGitbranch_with_hyphen3036579510/001' 64/pkg/tool/linux_amd64/vet GOINSECURE g/x/crypto/interrev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b164/_pkg_.a cfg 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name mLsRemoteWithRealGitbranch_with_hyphen3036579510/001' 64/pkg/tool/linux_amd64/vet GOINSECURE b/gh-aw/pkg/tty GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b098/_pkg_.a cfg x_amd64/vet GOINSECURE b/gh-aw/pkg/logg/tmp/js-hash-test-4261885520/test-hash.js GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 cfg 64/pkg/tool/linux_amd64/vet GOINSECURE ntio/asm/cpu/cpurev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b163/_pkg_.a GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE g/x/crypto/cryptrev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b011/ GOMODCACHE 64/pkg/tool/linutest@example.com env ithub/workflows cfg x_amd64/compile GOINSECURE 955208/b011/memcinit ache/go/1.25.8/x64/src/runtime/muser.email x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE l/buffer GOMODCACHE 64/pkg/tool/linutest@example.com rtcf�� 3660151874 tmain.go cfg GOINSECURE nal/fips140tls GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-dwarf=false (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b011/ GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b173/_pkg_.a GO111MODULE tants.test GOINSECURE 955208/b011/memmrev-parse ache/go/1.25.8/x--git-dir tants.test (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b078/ GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b203/_pkg_.a go ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE g/x/text/unicodeinit ache/go/1.25.8/x64/src/syscall/j/tmp/TestHashStability_SameInputSameOutput2930459241/001/stabili.artifacts[].name ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b011/ GOMODCACHE 64/pkg/tool/linux_amd64/vet env til.go o 64/pkg/tool/linux_amd64/compile GOINSECURE fips140/ecdh ache/go/1.25.8/x--show-toplevel 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b011/ GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b181/_pkg_.a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE 955208/b011/rt0_rev-parse ache/go/1.25.8/x--show-toplevel 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/scripts/lint_error_messages_test.go env 3660151874 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 955208/b078/syma/home/REDACTED/work/gh-aw/gh-aw/.github/workflows/auto-triage-issues.md 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json eyset.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 955208/b029/ GOMODCACHE 64/pkg/tool/linumyorg rtcf�� mpiledOutput1493674778/001 cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 955208/b029/emptrev-parse ache/go/1.25.8/x--show-toplevel 64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git 955208/b122/_pkggit cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git fq9m/dOvw0liy9-Z/bin/sh GO111MODULE ache/go/1.25.8/xgit-upload-pack 'origin' git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha edOutput1316457716/001 cfg 64/pkg/tool/linux_amd64/vet GOINSECURE boring GOMODCACHE 64/pkg/tool/linux_amd64/vet stlo�� 955208/b248/_pkg_.a 3NxN/fOrMapTM_SttVIFB3NxN ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE b/gh-aw/pkg/workremote GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build616046786/b421/importcfg -pack /tmp/go-build616046786/b421/_testmain.go env successfully" GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json fer.go x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE mcpgodebug GOMODCACHE x_amd64/vet env 5981682/001 5981682/002/work x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha adata/main.go GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env lGitmain_branch1835981682/001' lGitmain_branch1835981682/001' x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha edOutput1316457716/001 cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 955208/b036/syma--show-toplevel 64/pkg/tool/linux_amd64/vet env -json cfg ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 955208/b207/_pkg_.a gNV_/-ERQMY_tDmUJytyNgNV_ cfg GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuconfig (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json n/codec.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo -importcfg /tmp/go-build616046786/b413/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil_test.go env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/owner/repo/contents/file.md
    • Triggering command: /tmp/go-build616046786/b396/cli.test /tmp/go-build616046786/b396/cli.test -test.testlogfile=/tmp/go-build616046786/b396/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json x86.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 4, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add new constants.DefaultEngine and refactor usages Add DefaultEngine constant and replace semantic-default uses of CopilotEngine Apr 4, 2026
Copilot AI requested a review from dsyme April 4, 2026 19:09
Copilot finished work on behalf of dsyme April 4, 2026 19:09
@dsyme dsyme marked this pull request as ready for review April 4, 2026 19:15
Copilot AI review requested due to automatic review settings April 4, 2026 19:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a DefaultEngine constant to decouple “default engine selection” from the concrete CopilotEngine identifier, and updates call sites that were using Copilot as a semantic default.

Changes:

  • Added constants.DefaultEngine (currently set to CopilotEngine) in engine_constants.go.
  • Updated default-engine comparisons/initialization in the add workflow flows to use DefaultEngine.
  • Updated EngineRegistry.GetDefaultEngine() to use constants.DefaultEngine instead of a hardcoded "copilot".
Show a summary per file
File Description
pkg/workflow/agentic_engine.go Uses constants.DefaultEngine for registry default-engine lookup.
pkg/constants/engine_constants.go Adds DefaultEngine constant (currently Copilot).
pkg/constants/constants_test.go Asserts DefaultEngine == CopilotEngine.
pkg/cli/add_interactive_engine.go Initializes and checks “still default” state via DefaultEngine.
pkg/cli/add_command.go Skips writing engine: frontmatter when override equals DefaultEngine.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 2

Comment thread pkg/workflow/agentic_engine.go Outdated
Comment thread pkg/cli/add_command.go Outdated
dsyme and others added 2 commits April 4, 2026 20:26
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dsyme dsyme merged commit fc60e34 into main Apr 4, 2026
@dsyme dsyme deleted the copilot/define-default-engine-constant branch April 4, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review contants.CopilotEngine uses for default

3 participants