refactor: remove dead code, thin wrappers, and duplicate logic identified in semantic clustering analysis

pkg/cli/audit_cross_run_render.go

@@ -81,9 +81,9 @@ func renderCrossRunReportMarkdown(report *CrossRunAuditReport) {
 			fmt.Printf("| Avg | Min | Max |\n")
 			fmt.Printf("|-----|-----|-----|\n")
 			fmt.Printf("| %s | %s | %s |\n",
-				formatDurationNs(mt.AvgDurationNs),
-				formatDurationNs(mt.MinDurationNs),
-				formatDurationNs(mt.MaxDurationNs))
+				timeutil.FormatDurationNs(mt.AvgDurationNs),
+				timeutil.FormatDurationNs(mt.MinDurationNs),
+				timeutil.FormatDurationNs(mt.MaxDurationNs))
 			fmt.Println()
 		}
 	}
@@ -193,7 +193,7 @@ func renderCrossRunReportMarkdown(report *CrossRunAuditReport) {
 			}
 			durStr := "—"
 			if run.Duration > 0 {
-				durStr = formatDurationNs(int64(run.Duration))
+				durStr = timeutil.FormatDurationNs(int64(run.Duration))
 			}
 			fmt.Printf("| %d | %s | %s | %s | %s | %s | %s | %s | %d | %d |\n",
 				run.RunID, run.WorkflowName, run.Conclusion, durStr,
@@ -249,9 +249,9 @@ func renderCrossRunReportPretty(report *CrossRunAuditReport) {
 		}
 		if mt.AvgDurationNs > 0 {
 			fmt.Fprintf(os.Stderr, "  Duration: avg=%s  min=%s  max=%s\n",
-				formatDurationNs(mt.AvgDurationNs),
-				formatDurationNs(mt.MinDurationNs),
-				formatDurationNs(mt.MaxDurationNs))
+				timeutil.FormatDurationNs(mt.AvgDurationNs),
+				timeutil.FormatDurationNs(mt.MinDurationNs),
+				timeutil.FormatDurationNs(mt.MaxDurationNs))
 		}
 		fmt.Fprintln(os.Stderr)
 	}
@@ -339,7 +339,7 @@ func renderCrossRunReportPretty(report *CrossRunAuditReport) {
 			}
 			durStr := ""
 			if run.Duration > 0 {
-				durStr = "  dur=" + formatDurationNs(int64(run.Duration))
+				durStr = "  dur=" + timeutil.FormatDurationNs(int64(run.Duration))
 			}
 			if !run.HasData {
 				fmt.Fprintf(os.Stderr, "  Run #%-12d  %-30s  %-10s  (no firewall data)%s%s%s  mcp_errors=%d  errors=%d\n",
@@ -387,11 +387,6 @@ func formatRunIDs(ids []int64) string {
 	return strings.Join(parts, ", ")
 }
 
-// formatDurationNs formats a nanosecond duration as a human-readable string.
-func formatDurationNs(ns int64) string {
-	return timeutil.FormatDurationNs(ns)
-}
-
 // safePercent returns percentage of part/total, returning 0 when total is 0.
 func safePercent(part, total int) float64 {
 	if total == 0 {

pkg/cli/audit_report_render.go

@@ -14,6 +14,7 @@ import (
 	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/github/gh-aw/pkg/stringutil"
+	"github.com/github/gh-aw/pkg/timeutil"
 )
 
 // renderJSON outputs the audit data as JSON
@@ -1062,7 +1063,7 @@ func renderTokenUsage(summary *TokenUsageSummary) {
 		console.FormatNumber(summary.TotalOutputTokens),
 		console.FormatNumber(cacheTokens))
 	fmt.Fprintf(os.Stderr, "  Requests:   %d (avg %s)\n",
-		summary.TotalRequests, FormatDurationMs(summary.AvgDurationMs()))
+		summary.TotalRequests, timeutil.FormatDurationMs(summary.AvgDurationMs()))
 	if summary.CacheEfficiency > 0 {
 		fmt.Fprintf(os.Stderr, "  Cache hit:  %.1f%%\n", summary.CacheEfficiency*100)
 	}

pkg/cli/logs_github_api.go

@@ -15,12 +15,12 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"slices"
 	"strconv"
 	"strings"
 
 	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/logger"
-	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/github/gh-aw/pkg/workflow"
 )
 
@@ -283,7 +283,7 @@ func listWorkflowRunsWithPagination(opts ListWorkflowRunsOptions) ([]WorkflowRun
 		}
 
 		for _, run := range runs {
-			if sliceutil.Contains(agenticWorkflowNames, run.WorkflowName) {
+			if slices.Contains(agenticWorkflowNames, run.WorkflowName) {
 				agenticRuns = append(agenticRuns, run)
 			}
 		}

pkg/cli/mcp_permissions.go

@@ -4,10 +4,10 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"slices"
 	"strings"
 	"time"
 
-	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/github/gh-aw/pkg/workflow"
 	"github.com/modelcontextprotocol/go-sdk/jsonrpc"
 )
@@ -89,7 +89,7 @@ func validateMCPWorkflowName(workflowName string) error {
 
 	// Check if it's a valid GitHub Actions workflow name
 	agenticWorkflowNames, nameErr := getAgenticWorkflowNames(false)
-	if nameErr == nil && sliceutil.Contains(agenticWorkflowNames, workflowName) {
+	if nameErr == nil && slices.Contains(agenticWorkflowNames, workflowName) {
 		mcpLog.Printf("Workflow name is valid GitHub Actions workflow name: %s", workflowName)
 		return nil
 	}

pkg/cli/mcp_schema_test.go

@@ -4,10 +4,10 @@ package cli
 
 import (
 	"encoding/json"
+	"slices"
 	"testing"
 	"time"
 
-	"github.com/github/gh-aw/pkg/sliceutil"
 	"github.com/google/jsonschema-go/jsonschema"
 )
 
@@ -140,7 +140,7 @@ func TestGenerateSchema(t *testing.T) {
 		// Check that items is an array type
 		// In v0.4.0+, nullable slices use Types []string with ["null", "array"]
 		// instead of Type string with "array"
-		isArray := itemsProp.Type == "array" || sliceutil.Contains(itemsProp.Types, "array")
+		isArray := itemsProp.Type == "array" || slices.Contains(itemsProp.Types, "array")
 		if !isArray {
 			t.Errorf("Expected items to be an array type, got Type='%s', Types=%v", itemsProp.Type, itemsProp.Types)
 		}

pkg/cli/mcp_tool_schemas_test.go

@@ -4,9 +4,8 @@ package cli
 
 import (
 	"encoding/json"
+	"slices"
 	"testing"
-
-	"github.com/github/gh-aw/pkg/sliceutil"
 )
 
 // TestMCPToolOutputSchemas verifies that output schemas are correctly generated for MCP tools
@@ -102,7 +101,7 @@ func TestMCPToolOutputSchemas(t *testing.T) {
 		// This will be an array schema
 		// In v0.4.0+, nullable arrays use Types []string with ["null", "array"]
 		// instead of Type string with "array"
-		isArray := schema.Type == "array" || sliceutil.Contains(schema.Types, "array")
+		isArray := schema.Type == "array" || slices.Contains(schema.Types, "array")
 		if !isArray {
 			t.Errorf("Expected schema to be an array type, got Type='%s', Types=%v", schema.Type, schema.Types)
 		}

pkg/cli/token_usage.go

@@ -264,12 +264,6 @@ func (s *TokenUsageSummary) AvgDurationMs() int {
 	return s.TotalDurationMs / s.TotalRequests
 }
 
-// FormatDurationMs formats milliseconds as a human-readable string.
-// Deprecated: Use timeutil.FormatDurationMs instead.
-func FormatDurationMs(ms int) string {
-	return timeutil.FormatDurationMs(ms)
-}
-
 // ModelRows returns the by-model data as sorted rows for console rendering
 func (s *TokenUsageSummary) ModelRows() []ModelTokenUsageRow {
 	rows := make([]ModelTokenUsageRow, 0, len(s.ByModel))
@@ -287,7 +281,7 @@ func (s *TokenUsageSummary) ModelRows() []ModelTokenUsageRow {
 			CacheWriteTokens: usage.CacheWriteTokens,
 			EffectiveTokens:  usage.EffectiveTokens,
 			Requests:         usage.Requests,
-			AvgDuration:      FormatDurationMs(avgDur),
+			AvgDuration:      timeutil.FormatDurationMs(avgDur),
 		})
 	}
 	// Sort by total tokens descending

pkg/cli/token_usage_test.go

@@ -8,6 +8,7 @@ import (
 	"testing"
 
 	"github.com/github/gh-aw/pkg/testutil"
+	"github.com/github/gh-aw/pkg/timeutil"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -230,7 +231,7 @@ func TestFormatDurationMs(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.expected, func(t *testing.T) {
-			assert.Equal(t, tt.expected, FormatDurationMs(tt.ms), "FormatDurationMs(%d)", tt.ms)
+			assert.Equal(t, tt.expected, timeutil.FormatDurationMs(tt.ms), "FormatDurationMs(%d)", tt.ms)
 		})
 	}
 }