Java: Replace MethodAccess, LValue, RValue with more intuitive names. Introduce NewClassExpr. #14575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and MethodAccess.
Also rename and aliases a couple of uses of Access noted along the way.
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
aschackmull
reviewed
Oct 24, 2023
Co-authored-by: Anders Schack-Mulligen <[email protected]>
Co-authored-by: Anders Schack-Mulligen <[email protected]>
aschackmull
previously approved these changes
Oct 24, 2023
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
LGTM. I checked many MethodAccess renames, but not all of them, as there were a lot.
aschackmull
previously approved these changes
Oct 24, 2023
aschackmull
previously approved these changes
Oct 24, 2023
atorralba
approved these changes
Oct 24, 2023
Contributor
atorralba
left a comment
atorralba
left a comment
There was a problem hiding this comment.
Rubber-stamping @aschackmull's approval.
| } | ||
|
|
||
| from MethodAccess ma | ||
| from MethodCall ma |
Contributor
There was a problem hiding this comment.
Should MethodCall variables named ma be renamed to mc?
Contributor
Author
There was a problem hiding this comment.
Ideally yes, but it's a harder transformation to script!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend reviewing commit-by-commit, which separates the mass-renames from the substantial changes.