Conversation
Recommended the CERN OHL v2 family of licenses and linked to software licenses with similar terms. Also added mention of the Creative Commons licenses often used for hardware.
|
FWIW, this project took special care to properly apply the guidelines to use the S variant of the license (see discussion). The guidelines are quite long. I will try to extract the main features for the how field of the YAML files. |
Clarify use guidelines of p variant
Avoid word "virally"
Clarify usage guidelines for S variant of CERN OHL v2
Clarify usage guidelines for W variant of CERN OHL v2
|
Some proposed changes here. In general, I like the way @nytpu used the note field to refer the the user guide of each variant. I just added a quick reference to the disclaimer of warranties which can be important for hardware, and the source location which ultimately can help the recipient of a piece of hardware find the design for that object. I also propose to avoid using the term "viral" which can have a negative connotation. |
|
@j-sp your proposed changes look fine to me. I'd recommend shortening a bit by making the word "recommends" be link text (with the link being the one in the next sentence) and deleting the next sentence. |
|
Thanks @mlinksva, done. @julianstirling, tell me if there is anything else I can help with. |
|
Thanks @j-sp I have added your commits to the PR. I think this should be ready once the checks complete. |
|
I get lots of errors when I run locally but I fixed the specific one that seemed to fail on the CI |
|
I think this is ready to go? 🎉 |
|
Two comments on the description, replicated across the 3 variants:
Make plural as there is no "the CERN OHL", and "with hardware in mind" is redundant, it's in the name. Maybe there's a way to address this and segue into below fix:
Is there another way to characterize the difference? Most software licenses of a similar vintage also license patents. |
|
Thanks @mlinksva. If we need to better characterize the difference with respect to other licenses, I'd go for a separate description for each variant. In the case of the S variant, I'd propose:
I realize this is very long. See https://youtu.be/6wvEgQ5iWoc?t=1490 for the rationale. Let me know if I should attempt to condense it, and to which extent. |
|
For the W variant, I'd propose:
|
|
And for the P variant:
|
|
@mlinksva, I am happy to add the text that @j-sp has suggested to each of the three licenses if we are all agreed. On the point of if "with hardware in mind" is redundant... it largely is but it is also a point I think that is worth stressing and it is hard to stress well without redundancy. In the open hardware community we see many people new to the field applying software licenses to hardware, even ones with software in the name! |
If these new paragraphs are meant to replace the current
I understand you are trying to condense the text, but I believe in this case the additional length might be worth the clarity that describing these properties explicitly brings. |
|
Thanks @waldyrious, I fully see your point. If clarity is key and space is not an issue, how about this for the S variant?
|
|
I'm not a maintainer of this project, but IMHO I'd rather have the information explicitly stated, yeah. My only suggestion would be to connect the last sentence with what comes before, e.g.
or
(or some variant thereof). But that's a minor point — let's see what @mlinksva thinks about the overall expansion before bikeshedding the text :) |
|
I'll review again when I have a block of free time later in the week -- the descriptions, and want to make sure I understand the permissions/conditions/limitations for each license are appropriate since these are relatively novel among the licenses we have cataloged. My bias is brevity for the descriptions, and avoiding subjective statements like "carefully drafted" but feel free to bikeshed further if you feel like it. 😄 Many thanks for getting this PR into shape! |
|
Small refinements to the proposed texts, hopefully capturing the suggestions of @waldyrious and @mlinksva except for brevity. We should be able to shorten them if needed. S variant:
W variant:
P variant:
|
|
@mlinksva, sorry to pester. If you are happy with the wording above I'll move it into the PR. If your preferred workflow is me just to commit these changes and look again I can do that. I am just conscious that you might not want loads more commits whilst the language is tweaked. |
|
The metadata looks ok, though I wonder if W variant's "external material" is really closer to The text looks identical to the versions on the CERN site, which I imagine it is from. Not to address here, but noting there are some very small differences between that text and what is recorded in SPDX, particularly the capitalization of |
|
The descriptions in the comment above are longer than any currently; I should add a test limiting to 500 characters, which is longer than any in the repository now. The ones in committed are closer. I don't really care about whether things are worked out in comments or commits, but I'll go ahead and make suggestions as a review. |
mlinksva
left a comment
There was a problem hiding this comment.
Misc suggestions, not strongly attached to them.
|
I agree about changing from same-license--file to same-license--library in the W variant. The spirit of the license text is more about interfaces than about files. This can cover cases where the proprietary bit is a small component in an otherwise larger W design, so the library metaphor would not really apply, but neither would the file one. I believe library is a closer match. |
|
Thanks for all the pointers @j-sp. I think this is ready to merge and will do so soon, but feel free to propose further tweaks either before or after. |
|
Thanks @mlinksva, I just noticed an extra space after the comma in the file for the P variant of the licence: "A permissive license for hardware designs, with". All the rest looks good to me. |
|
Great to see this merged! Thanks all! |
This PR contains all the commits from #854 adding the CERN-OHL v2 family of licenses. (See also the discussion in issue/fixes #853)
This remains a draft whilst we check and tweak the "how" field
Requirements
1. The license must have an SPDX identifier. If your license isn't registered with SPDX, please request that it be added.
2. The license must be listed on one of the following approved lists of licenses:
3. The license must be used in at least 1,000 public repositories. This may be documented, for example, with a GitHub code search.
As noted in #853, there are a considerable number of projects using the CERN-OHL family of licenses.
This requirement appears to be to show the license is notable enough for inclusion. As the Open Hardware community is still settling on how best to share hardware, this increases the number of platforms that need to be searched. We provide the following further considerations:
4. 3 notable projects using the license must be identified. These must have straightforward LICENSE files which serve as examples newcomers can follow and that could be detected by licensee if it knew about the license.
As discussed in #854 this PR updates the projects.