Improve for codeception 5 and PHP 8.1#3
Merged
ggiak merged 2 commits intoggiak:masterfrom Jan 20, 2023
Merged
Conversation
Owner
|
@koehnlein Thanks for the contribution. will check soon and update. |
ggiak
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Enable multi session test * Update for PHP 8.1
ggiak
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Enable multi session test * Update for PHP 8.1
ggiak
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Enable multi session test * Update for PHP 8.1
ggiak
added a commit
that referenced
this pull request
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found your Pull Request Codeception#78 and saw, the test in the pipeline has failed.
So I investigated and found, the multi session testing needs some additional configuration since codeception 3 https://codeception.com/04-24-2019/codeception-3.0.html This was not an issue until now, because the old pipeline used codeception 2.
And while I did the changes and tested with my own environment, I found another PHP 8.1 issue, where float number have been passed, but integers are required.
Would be great, if you could merge this and update your Pull Request.
Thank you.