feat(preprod): Add distribution_error_code filter to list builds#109491
feat(preprod): Add distribution_error_code filter to list builds#109491runningcode merged 4 commits intomasterfrom
Conversation
Add a distribution_error_code query parameter to the list builds endpoint so the frontend can filter builds by their distribution error state (no_quota, skipped, processing_error). Also fix a bug in reset_artifact_data where distribution-specific error fields (installable_app_error_code, installable_app_error_message) were not cleared on rerun, leaving stale error state on artifacts that subsequently succeeded. Refs EME-842 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
| preprod_artifact.error_code = None | ||
| preprod_artifact.error_message = None | ||
| preprod_artifact.save(update_fields=["state", "error_code", "error_message", "date_updated"]) | ||
| preprod_artifact.installable_app_error_code = None |
There was a problem hiding this comment.
This addresses this comment: #109062 (comment)
| preprod_artifact.error_code = None | ||
| preprod_artifact.error_message = None | ||
| preprod_artifact.save(update_fields=["state", "error_code", "error_message", "date_updated"]) | ||
| preprod_artifact.installable_app_error_code = None |
Move the distribution_error_code filter from the old list builds endpoint to artifact_search.py, following the size_state pattern used by the new builds endpoint. Also add the search key to the frontend allowed keys and update the TS distribution info type with error_code and error_message fields. Refs EME-842 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
runningcode
force-pushed
the
runningcode/preprod-list-builds
branch
from
fba0d9c to
6331f21
Compare
| 'build_configuration_name', | ||
| 'build_number', | ||
| 'build_version', | ||
| 'distribution_error_code', |
There was a problem hiding this comment.
I think this happens to be fine because MOBILE_BUILDS_ALLOWED_KEYS isn't used anywhere a user could get at it - but ideally we should roll out UI changes separately from backend changes. Since the deployments aren't synchronized the user can end up with a frontend version which know about some field - with a backend that will error if that field is used for example.
2 participants
Summary
distribution_error_codequery parameter to the list builds endpoint, allowing the frontend to filter builds by their distribution error state (no_quota,skipped,processing_error)reset_artifact_datawhereinstallable_app_error_codeandinstallable_app_error_messagewere not cleared on rerun, leaving stale error state on artifacts that subsequently succeededRefs EME-842