fix: InvalidOperationException sending attachments on Android with LLVM enabled#4276
Merged
bruno-garcia merged 2 commits intomainfrom Jun 12, 2025
Merged
fix: InvalidOperationException sending attachments on Android with LLVM enabled#4276bruno-garcia merged 2 commits intomainfrom
bruno-garcia merged 2 commits intomainfrom
Conversation
…th LLVM enabled Resolves #3101: - #3101 Also see: - CA2022: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2022 - CA1835: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1835
bruno-garcia
approved these changes
Jun 12, 2025
| } | ||
|
|
||
| var read = await _innerStream.ReadAsync(buffer, offset, actualCount, cancellationToken) | ||
| // See https://github.com/getsentry/sentry-dotnet/issues/3101 |
Member
There was a problem hiding this comment.
off, some .NET bug? how can we avoid this from happening again?
Member
There was a problem hiding this comment.
Don't we have treat-warning-as-error on?
Member
There was a problem hiding this comment.
I believe we only have the Default ruleset enabled, depending on the .NET SDK version.
We could enable All rules, and also lock/pin to a specific .NET SDK ruleset for deterministic builds.
Opened new issue as follow-up for more code analysis rules and diagnostics: #4287
Collaborator
Author
There was a problem hiding this comment.
Don't we have treat-warning-as-error on?
We do but the analyzers for this error only appear to trigger in the .NET 10 SDK (we weren't getting any errors before that).
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This was referenced Mar 10, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3101:
Also see: