feat(snapshots): Add diff_threshold field to snapshot manifest#3259
Merged
NicoHinderling merged 4 commits intomasterfrom Apr 9, 2026
Merged
feat(snapshots): Add diff_threshold field to snapshot manifest#3259NicoHinderling merged 4 commits intomasterfrom
NicoHinderling merged 4 commits intomasterfrom
Conversation
Add an optional --diff-threshold CLI flag that is passed through to the backend in the snapshot manifest. When set, Sentry will only report images as changed if their pixel difference exceeds the given threshold (e.g. 0.01 = 1%). Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
rbro112
approved these changes
Apr 9, 2026
szokeasaurusrex
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
--diff-thresholdCLI flag to thebuild snapshotscommand. The value is included in the snapshot manifest JSON sent to the backend.When set, Sentry will only report images as changed if their pixel difference percentage exceeds the given threshold (e.g.
0.01= only report changes >= 1%). The backend does not yet consume this field — a follow-up PR ingetsentry/sentrywill read and apply it during comparison.Changes:
SnapshotsManifest: newdiff_threshold: Option<f64>field, skipped whenNonemake_command: new--diff-threshold <THRESHOLD>CLI argumentexecute: wires the CLI value into the manifest