Photoshop Integration by tokejepsen · Pull Request #524 · getavalon/core

tokejepsen · 2020-02-05T11:29:19Z

What's changed?
This is the Photoshop integration which fixes #516

The best introduction to the integration is with the README

- Also add project manager.

- Creator - maintained_selection

- The Dispatch object cannot be stored if it needs to be called from a different thread. - Exposed `get_all_layers` and `read` for publish plugin development.

- "get_all_layers" to "get_layers_in_document" - added "get_layers_layers"

- "maintained_visibility" - "get_layers_in_document" - "get_layers_in_layers" - "com_objects"

- import_as_smart_object - containerise

- imprint - import_smart_object - replace_smart_object

This reverts commit f58268c.

tokejepsen · 2020-02-10T11:13:08Z

Sorry for all the commit spamming, but got the test to pass now.

davidlatwe · 2020-02-11T08:52:44Z

Nice work !
I see you mentioned about LayerSets was not a good fit for being a container in the comment of #516, but what about group ? Current container is a single layer object right ? Will it able to load another PSD file while preserving layers ?

tokejepsen · 2020-02-11T10:25:44Z

but what about group ?

What do you mean with group?
A LayerSet is a group in the javascript.

Current container is a single layer object right ?

Yeah, currently a container is a single layer, but you could essentially containerise multiple layers with the same metadata.

Will it able to load another PSD file while preserving layers ?

When using smart objects, the layers from a PSD gets flattened. Unless I'm missing a workflow?
Smart objects are the only way that I know of to reference media into Photoshop. There might be a method similar to our Nuke nodes referencing, but think that it'll be very complicated.

davidlatwe · 2020-02-11T10:36:10Z

A LayerSet is a group in the javascript.

Ah ! Did not know that, thought they were different things. Thanks !

but you could essentially containerise multiple layers with the same metadata.

If that's the case, could containerise accept a list of layers instead of single layer ?

When using smart objects, the layers from a PSD gets flattened.

So the COMObject which should be passed into containerise could be a smart object ?

Unless I'm missing a workflow?

No no, I was just imaging what would I have to do to referencing another PSD file or other kind of subsets that may have multiple images or layers.

davidlatwe · 2020-02-11T10:43:00Z

Unless I'm missing a workflow?

No no, I was just imaging what would I have to do to referencing another PSD file or other kind of subsets that may have multiple images or layers.

But if publishing or loading that kind of subset in Photoshop would make things too complicated from actual production needs, then I can ignore that. :)

tokejepsen · 2020-02-11T10:45:05Z

If that's the case, could containerise accept a list of layers instead of single layer ?

Sure, that is possible. Though I thought for the sake of simplicity of the function, have a single layer as argument would be better? Can always containerise multiple times.
Or is your argument that all other hosts (except Fusion) containerises multiple objects?

So the COMObject which should be passed into containerise could be a smart object ?

Yeah, could be any layer or LayerSet for that matter. In Photoshop layers are LayerSet and ArtLayer which translates to group and layer in the UI.
So if you figure out a way of read/loading multiple layers, you could just containerise a LayerSet (group) with all the layers in.

davidlatwe · 2020-02-11T11:37:52Z

If that's the case, could containerise accept a list of layers instead of single layer ?

Sure, that is possible. Though I thought for the sake of simplicity ... Or is your argument that all other hosts (except Fusion) containerises multiple objects?

After a good thought, I think it's not necessary for Photoshop. Plus, artist can only find stuff from that layer stack UI, so yeah, it's a good idea to keep things as simple as possible. 👍

So the COMObject which should be passed into containerise could be a smart object ?

Yeah, could be any layer or LayerSet for that matter.

Nice !

tokejepsen · 2020-02-12T11:58:13Z

This PR is waiting on #523 to be merged.

BigRoy · 2020-02-12T12:03:44Z

The problem with #523 is still this particular comment. That should need to be tested and made sure that Blender will continue to work.

tokejepsen · 2020-02-17T10:09:56Z

With 98503a6, this PR is ready to be merged.
Let me know what you think.

tokejepsen · 2020-03-12T10:12:38Z

The #527 actually has a generic server which we could use for all Adobe products.

Lets leave this PR open for now, and I might rework this PR.

BigRoy · 2020-10-01T11:05:41Z

@tokejepsen You mentioned potentially reworking this PR. Should we merge this as is and open an issue? Should we close this? I noticed Pype merged something like this. So this is usable? If so, is there any documentation? :)

tokejepsen · 2020-10-01T11:16:18Z

The Pype team have been using this in production, so there may be a couple of bugs from them. Otherwise, yeah, we could merge this.

The Pype team is also working on a second iteration using websocket and native javascript in PS for cross platform compatibility, so the question is whether we wanna wait for that.

@mkolar and @iLLiCiTiT can update about the production testing and second iteration.

tokejepsen · 2021-02-13T13:04:46Z

This PR has been superseded by the Pype, so it better for the code to come from there.

tokejepsen added 30 commits January 24, 2020 15:21

Working prototype

1ed084a

Convert Flask to vendorized Bottle server.

faa6f1e

Export start_server function

8bf549c

Fix workfile saving.

eeb0bc8

Revert using separate process for launching tools.

4df1b7e

- Also add project manager.

Using DOM for Photoshop communication

ba0463d

Condensed Photoshop server to one file.

89091f2

Implemented Photoshop required methods for creation

ade16ee

- Creator - maintained_selection

Prevent duplicate instances from being created.

fcd88d0

Remove redundant "warning" function.

7a7ec80

Make the integration more thread safe.

74d5140

- The Dispatch object cannot be stored if it needs to be called from a different thread. - Exposed `get_all_layers` and `read` for publish plugin development.

Fix Photoshop workio open.

531a5aa

Introduce com objects for Photoshop constants.

ffa8a86

Change lib functions

caad4cd

- "get_all_layers" to "get_layers_in_document" - added "get_layers_layers"

Maintain selection during creation.

7794267

Add maintained_visibility

0375143

Code cosmetics

75c72e2

Expose lib functions

8cebe13

- "maintained_visibility" - "get_layers_in_document" - "get_layers_in_layers" - "com_objects"

Redundant code

914582b

Expose functions

8a7c4c9

- import_as_smart_object - containerise

Adjust containerise and ls.

d1a22ba

Fix updating imprinted data.

c750ce4

Rename "import_as_smart_object" to "import_smart_object"

aa9663a

Add "replace_smart_object"

819866b

Expose functions

477b54d

- imprint - import_smart_object - replace_smart_object

Move server to tools for reusability.

9fedf6c

Replace get_layer_type with com_objects.

ac5dcf4

Improve documentation of functions.

22f2eaa

Add signed extension package.

e73a1d5

Photoshop integration documentation.

2da8e68

Revert "Remove doc example."

8af7fbf

This reverts commit f58268c.

tokejepsen requested a review from BigRoy February 10, 2020 11:13

tokejepsen added 4 commits February 11, 2020 12:20

Expose Dispatch.

e3a65b8

Improve doc string.

d746e3e

Merge branch 'master' into photoshop

aaebb03

Remove config argument from Photoshop install

4274059

tokejepsen mentioned this pull request Feb 12, 2020

CGWire to Avalon launch getavalon/docker#28

Open

tokejepsen added 2 commits February 14, 2020 12:58

Launch Photoshop and server together.

21bc3f6

Silence hound.

baa376d

tokejepsen mentioned this pull request Feb 17, 2020

Fix #514 #523

Closed

Always exec QApplication.

98503a6

tokejepsen added 2 commits February 17, 2020 12:30

Merge branch 'master' into photoshop

4d14d42

Fix for context and workfiles merge.

b64d259

Update README.md

7054dea

tokejepsen mentioned this pull request Jun 10, 2020

Photoshop ynput/avalon-core#142

Merged

tokejepsen closed this Feb 13, 2021

Conversation

tokejepsen commented Feb 5, 2020

Uh oh!

tokejepsen commented Feb 10, 2020

Uh oh!

davidlatwe commented Feb 11, 2020

Uh oh!

tokejepsen commented Feb 11, 2020

Uh oh!

davidlatwe commented Feb 11, 2020

Uh oh!

davidlatwe commented Feb 11, 2020

Uh oh!

tokejepsen commented Feb 11, 2020

Uh oh!

davidlatwe commented Feb 11, 2020

Uh oh!

tokejepsen commented Feb 12, 2020

Uh oh!

BigRoy commented Feb 12, 2020

Uh oh!

tokejepsen commented Feb 17, 2020

Uh oh!

tokejepsen commented Mar 12, 2020

Uh oh!

BigRoy commented Oct 1, 2020

Uh oh!

tokejepsen commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tokejepsen commented Feb 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tokejepsen commented Oct 1, 2020 •

edited

Loading